Wire together LRU garbage collection #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoltis
requested review from
mikelehen,
rsgowman,
ryanpbrewster,
schmidt-sebastian and
tonymeng
as code owners
gsoltis
requested review from
bojeil-google,
depoll,
Feiyang1 and
hiranya911
as code owners
Feiyang1
approved these changes
Nov 21, 2018
ryanpbrewster
approved these changes
Nov 21, 2018
Feiyang1
reviewed
Nov 21, 2018
mikelehen
suggested changes
Nov 30, 2018
| return this._firestoreClient.start(persistenceSettings); | ||
| return this._firestoreClient.start( | ||
| persistenceSettings, | ||
| this._config.settings.cacheSizeBytes |
There was a problem hiding this comment.
It's tempting to have an InternalPersistenceSettings type that includes cacheSizeBytes, since it looks pretty strange to have them separate, and we're always passing them together... WDYT?
The other option would be to rename persistenceSettings stuff to indexedDbPersistenceSettings or something, but I'm not really excited about that.
There was a problem hiding this comment.
I think something like InternalPersistenceSettings might work. I'll do that in a separate PR against this one to see what it looks like.
mikelehen
approved these changes
Dec 4, 2018
packages/firestore/test/unit/local/lru_garbage_collector.test.ts
Outdated
Show resolved
Hide resolved
added 3 commits
December 4, 2018 15:03
* Refactor PersistenceSettings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of firebase/firebase-android-sdk#68
Enables LRU garbage collection, sets the default theshold at 40mb.