Internal persistence settings #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoltis
requested review from
rsgowman,
schmidt-sebastian,
var-const,
wilhuff and
zxu123
as code owners
mikelehen
approved these changes
Dec 4, 2018
| } | ||
| } | ||
|
|
||
| export class MemoryPersistenceSettings {} |
There was a problem hiding this comment.
Just to verify my own understanding, this will potentially have cacheSizeBytes in the future (if we move MemoryPersistence to LRU to put web in parity with iOS / Android behavior)?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
PersistenceSettings. RemovesPersistenceSettingsin favor of more specific classes. Note that merge base is into the lru PR #1392