Skip to content

Send first open time in Remote Config fetch request #9663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions FirebaseRemoteConfig/Sources/RCNConfigSettings.m
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
static NSString *const kRCNGroupPrefix = @"frc.group.";
static NSString *const kRCNUserDefaultsKeyNamelastETag = @"lastETag";
static NSString *const kRCNUserDefaultsKeyNameLastSuccessfulFetchTime = @"lastSuccessfulFetchTime";
static NSString *const kRCNAnalyticsFirstOpenTimePropertyName = @"_fot";
static const int kRCNExponentialBackoffMinimumInterval = 60 * 2; // 2 mins.
static const int kRCNExponentialBackoffMaximumInterval = 60 * 60 * 4; // 4 hours.

Expand Down Expand Up @@ -359,16 +360,31 @@ - (NSString *)nextRequestWithUserProperties:(NSDictionary *)userProperties {

if (userProperties && userProperties.count > 0) {
NSError *error;
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:userProperties
options:0
error:&error];
if (!error) {
ret = [ret
stringByAppendingString:[NSString
stringWithFormat:@", analytics_user_properties:%@",
[[NSString alloc]
initWithData:jsonData
encoding:NSUTF8StringEncoding]]];

// Extract first open time from user properties and send as a separate field
NSNumber *firstOpenTime = userProperties[kRCNAnalyticsFirstOpenTimePropertyName];
NSMutableDictionary *remainingUserProperties = [userProperties mutableCopy];
if (firstOpenTime != nil) {
NSDate *date = [NSDate dateWithTimeIntervalSince1970:([firstOpenTime longValue] / 1000)];
NSISO8601DateFormatter *formatter = [[NSISO8601DateFormatter alloc] init];
NSString *firstOpenTimeISOString = [formatter stringFromDate:date];
ret = [ret stringByAppendingString:[NSString stringWithFormat:@", first_open_time:'%@'",
firstOpenTimeISOString]];

[remainingUserProperties removeObjectForKey:kRCNAnalyticsFirstOpenTimePropertyName];
}
if (remainingUserProperties.count > 0) {
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:remainingUserProperties
options:0
error:&error];
if (!error) {
ret = [ret
stringByAppendingString:[NSString
stringWithFormat:@", analytics_user_properties:%@",
[[NSString alloc]
initWithData:jsonData
encoding:NSUTF8StringEncoding]]];
}
}
}
ret = [ret stringByAppendingString:@"}"];
Expand Down
27 changes: 27 additions & 0 deletions FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ @interface RCNUserDefaultsManager (Test)
+ (NSUserDefaults *)sharedUserDefaultsForBundleIdentifier:(NSString *)bundleIdentifier;
@end

@interface RCNConfigSettings (Test)
- (NSString *)nextRequestWithUserProperties:(NSDictionary *)userProperties;
@end

typedef NS_ENUM(NSInteger, RCNTestRCInstance) {
RCNTestRCInstanceDefault,
RCNTestRCInstanceSecondNamespace,
Expand Down Expand Up @@ -1415,6 +1419,29 @@ - (void)testSetFetchTimeoutConfigSetting {
}
}

- (void)testFetchRequestWithUserProperties {
NSDictionary *userProperties = @{@"user_key" : @"user_value"};
NSString *req = [_settings nextRequestWithUserProperties:userProperties];

XCTAssertTrue([req containsString:@"analytics_user_properties:{\"user_key\":\"user_value\"}"]);
}

- (void)testFetchRequestWithFirstOpenTimeAndUserProperties {
NSDictionary *userProperties = @{@"_fot" : @1649116800000, @"user_key" : @"user_value"};
NSString *req = [_settings nextRequestWithUserProperties:userProperties];

XCTAssertTrue([req containsString:@"first_open_time:'2022-04-05T00:00:00Z'"]);
XCTAssertTrue([req containsString:@"analytics_user_properties:{\"user_key\":\"user_value\"}"]);
}

- (void)testFetchRequestFirstOpenTimeOnly {
NSDictionary *userProperties = @{@"_fot" : @1650312375543};
NSString *req = [_settings nextRequestWithUserProperties:userProperties];

XCTAssertTrue([req containsString:@"first_open_time:'2022-04-18T20:06:15Z'"]);
XCTAssertFalse([req containsString:@"analytics_user_properties"]);
}

#pragma mark - Public Factory Methods

- (void)testConfigureConfigWithValidInput {
Expand Down