Skip to content

Send first open time in Remote Config fetch request #9663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 18, 2022
Merged

Send first open time in Remote Config fetch request #9663

merged 4 commits into from
Apr 18, 2022

Conversation

karenyz
Copy link
Contributor

@karenyz karenyz commented Apr 16, 2022 •
edited
Loading

We want to send an extra first_open_time signal in the Remote Config fetch request. Corresponding Android PR

Analytics is returning an extra _fot property along with custom user properties. Extracting that property (if it exists) and appending to the fetch request in the format of an ISO 8601 string.

Tested in sample app and fetch request succeeds with the new field.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Apr 16, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseRemoteConfig

    TypeBase (136e71f)Merge (b470851)Diff
    CocoaPods?700 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/szoLQbl6J2.html

paulb777
paulb777 reviewed Apr 16, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. A few nits to clean up including addressing the build warnings causing pod lib lint to fail in CI.

htcgh
htcgh reviewed Apr 18, 2022
View reviewed changes
@karenyz karenyz requested review from paulb777 and htcgh April 18, 2022 22:06
@google-oss-bot
Copy link

google-oss-bot commented Apr 18, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from ? (136e71f) to 79.21% (b470851) by ?.

    11 individual files with coverage change

    FilenameBase (136e71f)Merge (b470851)Diff
    FIRConfigValue.m?58.70%?
    FIRRemoteConfig.m?82.41%?
    FIRRemoteConfigComponent.m?97.06%?
    RCNConfigContent.m?80.68%?
    RCNConfigDBManager.m?75.95%?
    RCNConfigExperiment.m?92.25%?
    RCNConfigFetch.m?79.40%?
    RCNConfigSettings.m?67.48%?
    RCNDevice.m?81.29%?
    RCNPersonalization.m?89.74%?
    RCNUserDefaultsManager.m?97.89%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eYP7n1GUW7.html

htcgh
htcgh requested changes Apr 18, 2022
View reviewed changes
@karenyz karenyz merged commit b58ae53 into master Apr 18, 2022
@karenyz karenyz deleted the kz-rc-new-user-targeting branch April 18, 2022 23:12
@firebase firebase locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@htcgh htcgh htcgh approved these changes

@richaurora richaurora Awaiting requested review from richaurora

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karenyz @google-oss-bot @paulb777 @htcgh