Skip to content

Allow null/NAN values in filters #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Allow null/NAN values in filters #6871

merged 3 commits into from
Nov 2, 2020

Conversation

thebrianchen
Copy link

Porting from Web and Android.

@thebrianchen thebrianchen requested a review from wilhuff October 30, 2020 03:04
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Oct 30, 2020
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,5 +1,9 @@
# Unreleased
- [Fixed] Remove explicit MobileCoreServices library linkage from podspec. (#6850)
- [fixed] Remove explicit MobileCoreServices library linkage from podspec. (#6850)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you're in here, could you move the period to the end of the sentence (i.e. after the closing paren)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Nov 2, 2020
@thebrianchen thebrianchen merged commit 1c1ca00 into master Nov 2, 2020
@thebrianchen thebrianchen deleted the bc/remove-null-check branch November 2, 2020 18:52
@firebase firebase locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants