Skip to content

Allow null and NaN values in filters #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

Allow null and NaN values in filters #2115

merged 1 commit into from
Oct 29, 2020

Conversation

thebrianchen
Copy link

Porting from web.

@thebrianchen thebrianchen self-assigned this Oct 28, 2020
@google-cla google-cla bot added the cla: yes Override cla label Oct 28, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (844ff28) Head (38d10a87) Diff
    aar 999 kB 999 kB -379 B (-0.0%)
    apk (release) 3.13 MB 3.13 MB -184 B (-0.0%)

Test Logs

Notes

Head commit (38d10a87) is created by Prow via merging commits: 844ff28 f5670b3.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-firestore

    SDK overall coverage changed from 46.80% (844ff28) to 46.82% (38d10a87) by +0.02%.

    Filename Base (844ff28) Head (38d10a87) Diff
    AbstractStream.java 36.90% 34.52% -2.38%
    AsyncQueue.java 77.89% 76.88% -1.01%
    FieldFilter.java 88.33% 88.46% +0.13%
    GrpcCallProvider.java 57.95% 68.18% +10.23%
    Query.java 3.96% 4.06% +0.10%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (38d10a87) is created by Prow via merging commits: 844ff28 f5670b3.

@thebrianchen thebrianchen changed the title allow null and NaN values in filters Allow null and NaN values in filters Oct 29, 2020
@thebrianchen thebrianchen requested a review from wilhuff October 29, 2020 16:15
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Oct 29, 2020
wilhuff
wilhuff approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Oct 29, 2020
@thebrianchen thebrianchen merged commit 1dc2837 into master Oct 29, 2020
@thebrianchen thebrianchen deleted the bc/allow-null-check branch October 29, 2020 18:16
@thebrianchen thebrianchen mentioned this pull request Oct 29, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @google-oss-bot @wilhuff