Skip to content

Don't delete apps that don't exist #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Don't delete apps that don't exist #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Firebase/Database/Api/FIRDatabase.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,12 @@ + (void)load {
NSMutableDictionary *instances = [self instances];
@synchronized (instances) {
FIRDatabase *deletedApp = instances[appName];
// Clean up the deleted instance in an effort to remove any resources still in use.
// Note: Any leftover instances of this exact database will be invalid.
[FRepoManager disposeRepos:deletedApp.config];
[instances removeObjectForKey:appName];
if (deletedApp) {
// Clean up the deleted instance in an effort to remove any resources still in use.
// Note: Any leftover instances of this exact database will be invalid.
[FRepoManager disposeRepos:deletedApp.config];
[instances removeObjectForKey:appName];
}
}
}];
}
Expand Down