Don't delete apps that don't exist

[schmidt-sebastian]

This fixes the crash in:

Error log:

2017-09-14 21:57:45.555 Alosra[40901:8313494] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSDictionaryM removeObjectForKey:]: key cannot be nil'
*** First throw call stack:
(
        0   CoreFoundation                      0x0000000103c1db0b __exceptionPreprocess + 171
        1   libobjc.A.dylib                     0x0000000103682141 objc_exception_throw + 48
        2   CoreFoundation                      0x0000000103bb73b4 -[__NSDictionaryM removeObjectForKey:] + 676
        3   Alosra                              0x0000000101fc15e8 __29+[FRepoManager disposeRepos:]_block_invoke + 554
        4   libdispatch.dylib                   0x00000001062ce05c _dispatch_client_callout + 8
        5   libdispatch.dylib                   0x00000001062abde6 _dispatch_barrier_sync_f_invoke + 346
        6   Alosra                              0x0000000101fc1397 +[FRepoManager disposeRepos:] + 136
        7   Alosra                              0x0000000101fa6e81 __19+[FIRDatabase load]_block_invoke + 242
        8   Foundation                          0x000000010319773e -[__NSObserver _doit:] + 303
        9   CoreFoundation                      0x0000000103bbcc2c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
        10  CoreFoundation                      0x0000000103bbcb29 _CFXRegistrationPost + 425
        11  CoreFoundation                      0x0000000103bbc892 ___CFXNotificationPost_block_invoke + 50
        12  CoreFoundation                      0x0000000103b80102 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1826
        13  CoreFoundation                      0x0000000103b7f261 _CFXNotificationPost + 673
        14  Foundation                          0x0000000103150ca4 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
        15  Alosra                              0x0000000101f90ec1 -[FIRApp deleteApp:] + 604
        16  Alosra                              0x0000000101f05795 _TFC6Alosra11AppDelegate11applicationfTCSo13UIApplication29didFinishLaunchingWithOptionsGSqGVs10DictionaryVSC29UIApplicationLaunchOptionsKeyP____Sb + 1413
        17  Alosra                              0x0000000101f06024 _TToFC6Alosra11AppDelegate11applicationfTCSo13UIApplication29didFinishLaunchingWithOptionsGSqGVs10DictionaryVSC29UIApplicationLaunchOptionsKeyP____Sb + 180
        18  UIKit                               0x00000001040379b7 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 299
        19  UIKit                               0x000000010403929c -[UIApplication _callInitializationDelegatesForMainScene:transitionContext:] + 4119
        20  UIKit                               0x000000010403f5e4 -[UIApplication _runWithMainScene:transitionContext:completion:] + 1709
        21  UIKit                               0x000000010403c7f3 -[UIApplication workspaceDidEndTransaction:] + 182
        22  FrontBoardServices                  0x0000000106ddb5f6 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 24
        23  FrontBoardServices                  0x0000000106ddb46d -[FBSSerialQueue _performNext] + 186
        24  FrontBoardServices                  0x0000000106ddb7f6 -[FBSSerialQueue _performNextFromRunLoopSource] + 45
        25  CoreFoundation                      0x0000000103bc3c01 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
        26  CoreFoundation                      0x0000000103ba90cf __CFRunLoopDoSources0 + 527
        27  CoreFoundation                      0x0000000103ba85ff __CFRunLoopRun + 911
        28  CoreFoundation                      0x0000000103ba8016 CFRunLoopRunSpecific + 406
        29  UIKit                               0x000000010403b08f -[UIApplication _run] + 468
        30  UIKit                               0x0000000104041134 UIApplicationMain + 159
        31  Alosra                              0x0000000101f068b7 main + 55
        32  libdyld.dylib                       0x000000010631a65d start + 1
        33  ???                                 0x0000000000000001 0x0 + 1
)

[ryanwilson]

Thanks for fixing this!

[paulb777]

Should we do a rebuild for the current milestone with this fix?

[schmidt-sebastian]

Should we do a rebuild for the current milestone with this fix?

I would be inclined to do so.