Encode the topic name when subscribing #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address the issue filed at: firebase/quickstart-ios#242, where a topic name containing a `%` character was failing. It turns out that the topic name was never being url-encoded.
paulb777
reviewed
Aug 30, 2017
|
Good point, @paulb777. I added a nil-check and I log a warning if the topic name somehow can't be encoded. Acknowledged about using the phrase "next release". Very good point. I've updated the comment. |
paulb777
approved these changes
Aug 30, 2017
ryanwilson
approved these changes
Aug 30, 2017
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
This should address the issue filed at: firebase/quickstart-ios#242, where a topic name containing a `%` character was failing. It turns out that the topic name was never being url-encoded.
christibbs
added a commit
that referenced
this pull request
Jan 25, 2019
* compile and run * unit tests pass and swift target compiles * dump build version in activity log * standardize cross sdk imports in firebase iam code (#211) standardize cross sdk imports & polish with style script * using new sample app for testing non-development fiam sdk (#213) * in-app messaging public interface cleanup (#216) * slim down public header files * move testing source files to their correct folders * compiles * style script fine-tune * adding root object creation methods to follow the firebse iOS convension * IAM url following refactor (#218) * @available not supported by blaze build yet (#220) * Clearcut integration for in-app messaging (#222) * Update iam-master to catch up with latest master (#223) * Support multiple triggers defined for the same iam message (#224) * FIAM Clearcut Client Implmentation Improvement (#226) * fixing action url bug and set auto dismiss to be 12 seconds (#227) * use official public api dns name (#233) * Logging firebase analytics events for fiam (#232) * Fine tuning of fiam's code for loading data from caches (#234) * fiam ui fine tuning before EAP (#235) * allow fiam SDK functions to be disabled/enabled dynamically (#247) * analytics event parameter name tuning (#253) * migrate off @import for fiam code (#261) * different modes for fiam sdk at runtime (#262) * realtime clearcut when in running in simulator (#265) * Update interface based on the Firebase API review feedback (#267) * check existence of fiam SDK resource bundle (#268) * handling api keys with application restrictions (#269) * fixing typo and refoctor for unit testing (#270) * fix color method name clash and layout adjust (#271) * Yongmao/layout issue and class rename (#273) * fix long text height calc error * rename class * fiam modal view layout tuning (#274) * test on device for ios client (#275) * dynamic testing mode handling (#277) * main header file comment update and run style.sh (#281) * honor global firebase auto data collection flag in fiam (#283) * honor global firebase auto data collection flag in fiam * address comments * tuning * address review comments * tuning for comments * Rename Core global data collection switch (#287) * Support displaying a messages defined as recurring (#286) * continue * Adjust some inapp messaging dependeces due to the firebase core changes from the upcoming release * bump up version for in-app messaging * Fix impression log clearing race condition bug. (#289) * fix impression handling race condition bug * podspec and interacting interfaces for new firebaseinappmessagingdisplay pod (#290) * create inapp messaging display podspec * Default fiam display UI implementation (#292) * Default fiam display UI implementation. Created the new pod for FirebaseInAppMessagingDisplay * Make FirebaseInAppMessaging headless (#293) * import path tuning * log test message events (#296) * respect fetch wait time from server (#297) * add changelog.md for fiam headless sdk (#300) * port the fetch wait time change back into github (#304) * remove resource bundle check for headless sdk * fix a bug in which the test-on-device message does not follow action url * Add category on NSString to interlace two strings, use it to obfuscate clearcut host name * Use FIR prefix to avoid collisions * Change method name for getting server hostname * Delete Swift example project, its coverage is already duplicated in the FIRInAppMessagingDisplay UITests * Miscellaneous open sourcing cleanup tasks * Convert FIAM to use the Analytics connector (#336) * Convert FIAM to use Analytics connector along with converting to the FIRLibrary component registration model. * Update interop headers for missing methods * Convert existing unit tests * Fix style for fiam sources (#342) * Clean up non-idiomatic ObjC method names * Clean up Swift test target from Podfile * Use dummy GoogleService-Info.plist and don't expose api keys (#343) * Update plist to include fake API keys * Remove changes in non fiam code from iam-master branch (#350) * Fix a few method and parameter naming nits * Fix comment typos in several files * Delete remaining Swift project files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the issue filed at: firebase/quickstart-ios#242, where a topic name containing a
%character was failing. It turns out that the topic name was never being url-encoded.