Skip to content

Add isEqual and hash for aggregate classes #10261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 26, 2022

No description provided.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments. Otherwise, LGTM. Thanks for filling out this implementation!

@wu-hui wu-hui requested a review from dconeybe September 27, 2022 16:03
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…dy/AggregateEquals

# Conflicts:
#	Firestore/Source/API/FIRAggregateQuerySnapshot.mm
@wu-hui wu-hui merged commit c0ec21a into revert-10252-revert-10246-wuandy/PublicCount Sep 27, 2022
@wu-hui wu-hui deleted the wuandy/AggregateEquals branch September 27, 2022 19:32
ehsannas added a commit that referenced this pull request Sep 28, 2022
* Revert "Revert "Public count (#10246)" (#10252)"

This reverts commit b695d99.

* Firestore: Re-write API docs for COUNT API (#10258)

* Add isEqual and hash for aggregate classes (#10261)

Co-authored-by: Denver Coneybeare <[email protected]>
Co-authored-by: Ehsan <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants