-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add isEqual and hash for aggregate classes #10261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wu-hui
merged 11 commits into
revert-10252-revert-10246-wuandy/PublicCount
from
wuandy/AggregateEquals
Sep 27, 2022
Merged
Add isEqual and hash for aggregate classes #10261
wu-hui
merged 11 commits into
revert-10252-revert-10246-wuandy/PublicCount
from
wuandy/AggregateEquals
Sep 27, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy/AggregateEquals
Generated by 🚫 Danger |
dconeybe
requested changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments. Otherwise, LGTM. Thanks for filling out this implementation!
dconeybe
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dy/AggregateEquals # Conflicts: # Firestore/Source/API/FIRAggregateQuerySnapshot.mm
ehsannas
added a commit
that referenced
this pull request
Sep 28, 2022
* Revert "Revert "Public count (#10246)" (#10252)" This reverts commit b695d99. * Firestore: Re-write API docs for COUNT API (#10258) * Add isEqual and hash for aggregate classes (#10261) Co-authored-by: Denver Coneybeare <[email protected]> Co-authored-by: Ehsan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.