Skip to content

Revert "Public count" #10252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Revert "Public count" #10252

merged 1 commit into from
Sep 23, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Sep 23, 2022

Reverts #10246

@dconeybe dconeybe assigned wu-hui and unassigned dconeybe Sep 23, 2022
@wu-hui wu-hui merged commit b695d99 into master Sep 23, 2022
@wu-hui wu-hui deleted the revert-10246-wuandy/PublicCount branch September 23, 2022 15:22
@dconeybe dconeybe mentioned this pull request Sep 23, 2022
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 87.88% (8aae6be) to 87.96% (2b5be47) by +0.08%.

    FilenameBase (8aae6be)Merge (2b5be47)Diff
    exception.cc23.68%84.21%+60.53%
    exception_apple.mm96.55%65.52%-31.03%
    leveldb_key.cc98.82%98.63%-0.20%
    leveldb_mutation_queue.cc92.42%93.56%+1.14%
    ordered_code.cc93.90%94.39%+0.49%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Wat9Yke6Ba.html

wu-hui added a commit that referenced this pull request Sep 23, 2022
@wu-hui wu-hui mentioned this pull request Sep 23, 2022
ncooke3 pushed a commit that referenced this pull request Sep 24, 2022
ncooke3 added a commit that referenced this pull request Sep 24, 2022
* [Firebase 10] Bump 9.X versions to 10.0.0

* Bump min. GTMSessionFetcher dep version to 2.1

* Bump min. GDT dep version to 9.2

* Bump min. GULs dep version to 7.8

* Fix unintentional nanopb replace

* Fix unintentional nanopb replace (2)

* Fix unintentional nanopb replace (3)

* Fix unintentional nanopb replace (4)

* Fix unintentional nanopb replace (4)

* Trigger all CI

* Bump FirebaseCombineSwift to 10

* Fix FirebaseStorage.podspec
I'm not sure what happened here. I had committed it during the rebase but guess not?

* Fix unintentional nanopb replace (5)

* Disable two tests to unblock staging

* Fix and re-enable FIROptions tests

* Update deployment targets in Firebase.podspec

* Add CHANGELOG entry for GTMSessionFetcher

* Fix AppCheck iOS availability

* Fix inadvertent API change (#10245)

* Docs update for Extensions and putFile (#10248)

* App google domain support (#10249)

Adding new 1p domain "app.google" support in FDL SDK.

* Remote Config Dynamic Property Wrapper (#10155)

* Separate GoogleUtilities Carthage build (#10250)

* Public count (#10246)

* Public Count

* Swift Test Commit

* Swift Format

* No extra whitespace

* Hopefully formatted.

* Change log and feedback.

* Revert "Public count (#10246)" (#10252)

This reverts commit 8aae6be.

* Make Firestore use FirebaseDataEncoder and FirebaseDataDecoder (re-implementation of #8858) (#9465)

* Bump tvOS minimum support version to 12.0

* [skip ci] Revert Gemfile

Co-authored-by: Paul Beusterien <[email protected]>
Co-authored-by: Eldhose M Babu <[email protected]>
Co-authored-by: Charlotte Liang <[email protected]>
Co-authored-by: wu-hui <[email protected]>
Co-authored-by: Morten Bek Ditlevsen <[email protected]>
ehsannas added a commit that referenced this pull request Sep 28, 2022
* Revert "Revert "Public count (#10246)" (#10252)"

This reverts commit b695d99.

* Firestore: Re-write API docs for COUNT API (#10258)

* Add isEqual and hash for aggregate classes (#10261)

Co-authored-by: Denver Coneybeare <[email protected]>
Co-authored-by: Ehsan <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants