Skip to content

Deprecate RunTransaction which takes a TransactionFunction. #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2021
Merged

Deprecate RunTransaction which takes a TransactionFunction. #512

merged 4 commits into from
Jul 12, 2021

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jul 6, 2021

No description provided.

@ehsannas ehsannas requested a review from var-const July 6, 2021 14:54
@google-cla google-cla bot added the cla: yes label Jul 6, 2021
@ehsannas ehsannas mentioned this pull request Jul 6, 2021
Merged
var-const
var-const suggested changes Jul 6, 2021
View reviewed changes
@var-const var-const assigned ehsannas and unassigned var-const Jul 6, 2021
@ehsannas ehsannas assigned var-const and unassigned ehsannas Jul 6, 2021
var-const
var-const previously approved these changes Jul 6, 2021
View reviewed changes
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Jul 6, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 6, 2021
@github-actions
Copy link

github-actions bot commented Jul 6, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @ehsannas on commit 42eca93
Last updated: Mon Jul 12 13:55 PDT 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [tvOS] [macos] [tvos_simulator_target]
(1 failed tests)  TestServerTimestampsWorkViaUpdate

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 6, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 6, 2021
@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jul 7, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 7, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 7, 2021
@ehsannas ehsannas assigned ehsannas and unassigned var-const Jul 7, 2021
@ehsannas
Copy link
Contributor Author

ehsannas commented Jul 7, 2021

We need to update our own test that uses this API as well:

/Users/runner/work/firebase-cpp-sdk/firebase-cpp-sdk/ta/firestore/iti/src/transaction_test.cc:119:42: error: 'RunTransaction' is deprecated [-Werror,-Wdeprecated-declarations]
  Future<void> future = TestFirestore()->RunTransaction(&transaction);

@ehsannas ehsannas removed the tests: failed This PR's integration tests failed. label Jul 7, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jul 10, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 10, 2021
@ehsannas
Copy link
Contributor Author

in today's episode of github actions failures we have:

  • SyntaxError: Non-ASCII character '\xe2' in file scripts/gha/it_workflow.py on line 60
  • FirebaseAuthTest.TestAnonymousSignin test failure
  • FirebaseDatabaseTest.TestInfoConnected test failure

this is super frustrating ... 😭

@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jul 10, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 10, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 10, 2021
@ehsannas
Copy link
Contributor Author

This time around, I'm getting these failures:

FirebaseMessagingTest.TestSubscribeAndUnsubscribe
BundleTest.LoadInvalidBundlesShouldFail

At least this time one of the test failures is in Firestore (even though it's probably a flake as it didn't fail in the previous two runs)...

Let's try again for the 6th time.

@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jul 10, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 10, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 10, 2021
@ehsannas ehsannas added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jul 12, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 12, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 12, 2021
@ehsannas ehsannas removed the tests: failed This PR's integration tests failed. label Jul 12, 2021
@ehsannas ehsannas merged commit 42eca93 into main Jul 12, 2021
@ehsannas ehsannas deleted the ehsann-deprecate-run-transaction branch July 12, 2021 18:36
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jul 12, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 12, 2021
@firebase firebase locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @var-const