Skip to content

Remove STLPort support from public API. #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2021
Merged

Remove STLPort support from public API. #510

merged 2 commits into from
Jul 6, 2021

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Jul 5, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 5, 2021
@ehsannas ehsannas self-assigned this Jul 5, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label Jul 5, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 5, 2021
@github-actions
Copy link

github-actions bot commented Jul 5, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @ehsannas on commit 12968c3
Last updated: Tue Jul 6 09:26 PDT 2021
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 5, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 5, 2021
@ehsannas ehsannas requested a review from var-const July 5, 2021 21:56
@ehsannas
Copy link
Contributor Author

ehsannas commented Jul 5, 2021

This PR is a combination of #486 (which I rolled back) and #494.

@ehsannas ehsannas assigned var-const and unassigned ehsannas Jul 5, 2021
var-const
var-const approved these changes Jul 5, 2021
View reviewed changes
@var-const var-const assigned ehsannas and unassigned var-const Jul 5, 2021
@ehsannas ehsannas merged commit 12968c3 into main Jul 6, 2021
@ehsannas ehsannas deleted the ehsann-remove-stlport branch July 6, 2021 14:31
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 6, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 6, 2021
@firebase firebase locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@var-const var-const var-const approved these changes

Assignees

@ehsannas ehsannas

Labels
cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsannas @var-const