Skip to content

CI enable integration test on Android Emulator #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 22, 2021
Merged

CI enable integration test on Android Emulator #376

merged 28 commits into from
Apr 22, 2021

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Apr 13, 2021 •
edited
Loading

In the workflow, enable test on android emulator in MacOS.
(Linux is disabled, because GitHub Linux Machine doesn't support hardware acceleration.)

Script that running game-loop test on emulator:
scripts/gha/test_simulator.py
A UI Test App that enable game-loop test:
scripts/gha/integration_testing/gameloop_android
Logic is in .kt files. And most of the .xml files are auto-generated res files.

To run the script locally (MacOS & Linux):
scripts/gha/test_simulator.py --testapp_dir testapp_dir
Prerequisite:

  1. Java 8
  2. Environment Variables:
// on MacOS:
JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk-8-latest/Contents/Home
ANDROID_HOME=/Users/user_name/Library/Android/sdk
// on Linux:
JAVA_HOME=/usr/local/buildtools/java/jdk8/
ANDROID_HOME=~/Android/Sdk

Workflow passed (admob,analytics):
https://github.com/firebase/firebase-cpp-sdk/runs/2402251148?check_suite_focus=true
firestore failed. Update: fixed by change timeout.

@google-cla google-cla bot added the cla: yes label Apr 13, 2021
@sunmou99 sunmou99 changed the title Enable test on android emulator Enable test on android emulator (MacOS) Apr 13, 2021
@sunmou99 sunmou99 requested a review from jonsimantov April 13, 2021 21:52
@sunmou99 sunmou99 changed the title Enable test on android emulator (MacOS) Enable test on android emulator Apr 13, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 14, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 14, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 14, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 14, 2021
@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Apr 15, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 15, 2021
@sunmou99
Copy link
Contributor Author

Looks good except some minor comments.
Small formatting nit is to check end of file new line.

In terms of 1) device flag names 2) summarize_test_results script. I'm gonna resolve them in a separate PR.

@sunmou99 sunmou99 requested a review from vimanyu April 21, 2021 02:02
jonsimantov
jonsimantov reviewed Apr 21, 2021
View reviewed changes
@sunmou99 sunmou99 requested a review from jonsimantov April 21, 2021 20:55
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 22, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 22, 2021
@github-actions
Copy link

github-actions bot commented Apr 22, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 3ac7579
Last updated: Thu Apr 22 02:05:27 PDT 2021
View integration test results

Platform Build failures Test failures
Android simulator (built on MacOS) storage
iOS simulator (built on MacOS)
(8 items)auth
database
firestore
functions
installations
instance_id
remote_config
storage

jonsimantov
jonsimantov previously approved these changes Apr 22, 2021
View reviewed changes
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 22, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 22, 2021
@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label Apr 22, 2021
@sunmou99 sunmou99 enabled auto-merge (squash) April 22, 2021 18:17
@sunmou99 sunmou99 dismissed vimanyu’s stale review April 22, 2021 18:27

Discussed with VJ

@sunmou99 sunmou99 requested a review from jonsimantov April 22, 2021 18:28
vimanyu
vimanyu approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunmou99 sunmou99 merged commit a69445d into main Apr 22, 2021
@sunmou99 sunmou99 deleted the feature/test-on-android-emulator branch April 22, 2021 18:46
@firebase firebase locked and limited conversation to collaborators May 23, 2021
@sunmou99 sunmou99 changed the title Enable test on android emulator CI enable integration test on Android Emulator Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vimanyu vimanyu vimanyu approved these changes

@cynthiajoan cynthiajoan Awaiting requested review from cynthiajoan

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunmou99 @vimanyu @jonsimantov