add return value description & put string into res

Author: sunmou99

scripts/gha/integration_testing/gameloop_android/app/build.gradle

@@ -8,7 +8,7 @@ android {
     defaultConfig {
         applicationId "com.google.firebase.gameloop"
         minSdkVersion rootProject.minSdk
-        targetSdkVersion rootProject.targetSDK
+        targetSdkVersion rootProject.targetSdk
         versionCode 1
         versionName "1.0"
 

scripts/gha/integration_testing/gameloop_android/app/src/androidTest/java/com/google/firebase/gameloop/GameLoopUITest.kt

@@ -4,6 +4,7 @@ import androidx.test.ext.junit.rules.ActivityScenarioRule
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import androidx.test.filters.SdkSuppress
 import androidx.test.platform.app.InstrumentationRegistry
+import androidx.test.platform.app.InstrumentationRegistry.getInstrumentation
 import androidx.test.uiautomator.By
 import androidx.test.uiautomator.UiDevice
 import androidx.test.uiautomator.Until
@@ -18,7 +19,6 @@ import org.junit.runner.RunWith
 class GameLoopUITest {
 
   companion object {
-    const val COMPLETE_TEST = "Game Loop Complete"
     const val GAMELOOP_TIMEOUT = 7 * 60 * 1000L
   }
 
@@ -35,7 +35,9 @@ class GameLoopUITest {
 
   @Test
   fun testLaunchGameLoop() {
-    val element = device.wait(Until.findObject(By.text(COMPLETE_TEST)), GAMELOOP_TIMEOUT)
+    val element = device.wait(
+      Until.findObject(By.text(getInstrumentation().targetContext.getString(R.string.test_complete))),
+      GAMELOOP_TIMEOUT)
     assertNotNull(element)
   }
 }

scripts/gha/integration_testing/gameloop_android/app/src/main/java/com/google/firebase/gameloop/MainActivity.kt

@@ -13,7 +13,6 @@ import java.io.File
 
 class MainActivity : AppCompatActivity(R.layout.activity_main) {
   companion object {
-    const val COMPLETE_TEST = "Game Loop Complete"
     const val GAMELOOP_INTENT = "com.google.intent.action.TEST_LOOP"
     const val TEST_LOOP_REQUEST_CODE = 1
   }
@@ -49,7 +48,7 @@ class MainActivity : AppCompatActivity(R.layout.activity_main) {
   override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
     super.onActivityResult(requestCode, resultCode, data)
     when (requestCode) {
-      TEST_LOOP_REQUEST_CODE -> testingTV.text = COMPLETE_TEST
+      TEST_LOOP_REQUEST_CODE -> testingTV.text = getString(R.string.test_complete)
     }
   }
 }

scripts/gha/integration_testing/gameloop_android/app/src/main/res/layout/activity_main.xml

@@ -8,7 +8,7 @@
   <TextView
       android:layout_width="wrap_content"
       android:layout_height="wrap_content"
-      android:text="Testing"
+      android:text="@string/testing"
       android:id="@+id/test"
       app:layout_constraintBottom_toBottomOf="parent"
       app:layout_constraintLeft_toLeftOf="parent"

scripts/gha/integration_testing/gameloop_android/app/src/main/res/values/strings.xml

@@ -1,3 +1,5 @@
 <resources>
   <string name="app_name">gameloop</string>
+  <string name="testing">Testing</string>
+  <string name="test_complete">Game Loop Complete</string>
 </resources>

scripts/gha/integration_testing/gameloop_android/build.gradle

@@ -25,7 +25,7 @@ ext {
     compileSdk = 28
     buildTools = '28.0.3'
     minSdk = 16
-    targetSDK = 28
+    targetSdk = 28
 }
 
 task clean(type: Delete) {

scripts/gha/test_simulator.py

@@ -56,6 +56,12 @@
 sdk id "system-images;android-29;google_apis", build tool version "29.0.3":
   --android_device "system-images;android-29;google_apis;x86;29.0.3"
 
+Returns:
+   1: No iOS/Android integration_test apps found
+   21: iOS Simulator created fail  
+   22: iOS gameloop app not found
+   23: build_testapps.json file not found
+   31: For android test, JAVA_HOME is not set to java 8
 """
 
 import json
@@ -131,21 +137,21 @@ def main(argv):
     device_id = _boot_simulator(device_name, device_os)
     if not device_id:
       logging.error("simulator created fail")
-      return 1
+      return 21
 
     # A tool that enable game-loop test. This is a XCode project
     ios_gameloop_project = os.path.join(current_dir, "integration_testing", "gameloop")
     ios_gameloop_app = _build_ios_gameloop(ios_gameloop_project, device_name, device_os)
     if not ios_gameloop_app:
       logging.error("gameloop app not found")
-      return 2
+      return 22
 
     config_path = os.path.join(current_dir, "integration_testing", "build_testapps.json")
     with open(config_path, "r") as configFile:
       config = json.load(configFile)
     if not config:
       logging.error("No config file found")
-      return 3
+      return 23
 
     for app_path in ios_testapps:
       bundle_id = _get_bundle_id(app_path, config)
@@ -164,7 +170,7 @@ def main(argv):
 
     if not _check_java_version():
       logging.error("Please set JAVA_HOME to java 8")
-      return 1
+      return 31
 
     _setup_android(platforms_version, build_tools_version, sdk_id)