Skip to content

Update ios and tvos simulator versions for GitHub runners (a second time) #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2023

Conversation

AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented May 19, 2023

Description

This is a followup to #1326.
That change updated from 16.1, 16.2 to 15.2, 15.4
This change updates ios simulator versions to 16.1, 16.1

Previously it was only the test that required 16.2 that was failing due to no simulator, and now there has also been a test run that failed because 15.x was unavailable. So stick to 16.1 as a version that is known to work.

Also note that ios 16.1 is associated with xcode 14.1, and the two failing runs linked above both mention xcode 14.1 as available.


Testing

Integration test run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/5019927558


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 19, 2023
@github-actions
Copy link

github-actions bot commented May 19, 2023

Integration test with FLAKINESS (succeeded after retry)

Requested by @AlmostMatt on commit 26c09e5
Last updated: Fri May 19 12:30 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  WriteBatchTest.TestUpdateFieldsWithDots
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@AlmostMatt AlmostMatt requested a review from jonsimantov May 19, 2023 01:43
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label May 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 19, 2023
@AlmostMatt AlmostMatt added the skip-release-notes Skip release notes check label May 19, 2023
@AlmostMatt AlmostMatt merged commit 26c09e5 into main May 19, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 19, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 19, 2023
@AlmostMatt AlmostMatt deleted the amatt-simulator-version2 branch May 19, 2023 21:13
@firebase firebase locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants