Skip to content

Update ios and tvos simulator versions for GitHub runners #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2023

Conversation

AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented May 17, 2023

Description

Update the ios and tvos simulator versions used by GitHub actions.
Previously ios_simulator_latest was failing.
Example of past failure:
https://github.com/firebase/firebase-cpp-sdk/actions/runs/5001905633/jobs/8962904059


Testing

Test run: https://github.com/firebase/firebase-cpp-sdk/actions/runs/5006266427


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 17, 2023
@github-actions
Copy link

github-actions bot commented May 17, 2023

❌  Integration test FAILED

Requested by @AlmostMatt on commit c6ec86a
Last updated: Wed May 17 16:54 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
[TEST] [FAILURE] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  ValidationTest.QueriesCannotBeSortedByAnUncommittedServerTimestamp
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@jonsimantov jonsimantov self-requested a review May 17, 2023 20:05
@AlmostMatt AlmostMatt added the skip-release-notes Skip release notes check label May 17, 2023
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 17, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 17, 2023
@AlmostMatt
Copy link
Contributor Author

The relevant ios tests succeeded:
https://github.com/firebase/firebase-cpp-sdk/actions/runs/5006266427

Android test failures are unrelated to this change.

@AlmostMatt AlmostMatt merged commit c6ec86a into main May 17, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: failed This PR's integration tests failed. labels May 17, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 17, 2023
@AlmostMatt AlmostMatt deleted the amatt-simulator_version branch May 19, 2023 21:13
@firebase firebase locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants