Add integration test workflow #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of this workflow is copied verbatim from the workflow to build the SDK. There are two new parts for the integration tests:
- Manual dispatch with input parameters that can be specified when triggering.
- Two new steps ('Prepare for integration tests' and 'Build and run integration tests').
vimanyu
reviewed
Jul 31, 2020
Instead of specifying the operating system input as a JSON, this will take a normal CSV string. A separate job, prepare_matrix, will run before the tests to convert the CSV to a JSON list. The conversion is done by using sed to replace a comma with a quoted comma, and then inserting that value into ["$(new_value)"] using command substitution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this workflow is copied verbatim from the workflow to build the SDK. The duplication means that most changes to the SDK build workflow will need to be mirrored into this one.
There are two new parts for the integration tests:
This PR is dependent on two other PRs:
#106
#103
This workflow is not set to run automatically. For now, it will only run on manual trigger. Which APIs to build/test, which platforms to build for, and which operating systems to run on can be specified when triggering.
Parameterizing the operating systems required a bit of hackery, as that requires modifying the job matrix. The input is supplied as a JSON list, and then fromJson converts it into valid YML. If and when Github implements a first party solution for this kind of thing, this should be easiest to migrate to that solution. Two alternatives were considered:
Once the two dependent PRs are in, Desktop (build + test) should work. Android (build) might work. iOS definitely won't work for the foreseeable future.