Add tools for C++ integration tests #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the tools needed to build and run C++ integration tests. These derive from the corresponding tools in google3, with some changes and exceptions: build_testapps.py and build_desktop_testapps.py have been merged into a single, simpler build_testapps.py. restore_secrets.py is a new script that decrypts the secret files in scripts/gha-encrypted and restores all the files/values that were stripped out when pushing the integration source code to Github. Except for the reverse ids in the Info.plists needed for iOS, which are not present yet. xcodebuild.py, provisioning.py and xcode_tool.rb are all for iOS, which is not yet supported until signing is figured out. This also includes a change to .gitignore to ignore temporary Python files, as well as unencrypted secrets.
vimanyu
reviewed
Jul 28, 2020
|
The reversed client ID can be extracted from GoogleService-Info.plist and google-services.json, if you want to just do that. |
Yeah that's a good call, simple to do and results in one fewer thing to maintain. |
The following changes have been made: - config_reader.py has been simplified to just return a plain data object containing all the needed config upfront. Thus it's only needed to call one function from the module once. - Added types to args in docstrings. - restore_secrets now restores the reverse id in Info.plists, using the value from the decrypted GoogleService-Info.plist as the source of truth.
vimanyu
reviewed
Jul 29, 2020
jonsimantov
requested changes
Jul 29, 2020
We've decided to use absl.flags as the flag-parsing library for Python in the repo. Also removed reverse id patching from the xcode tool, since that's being handled by the secret restoration script.
jonsimantov
approved these changes
Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the tools needed to build and run C++ integration tests.
These derive from the corresponding tools in the internal repo, with some changes and exceptions:
This also includes a change to .gitignore to ignore temporary Python files, as well as unencrypted secrets.
There are still a few things I think I could improved, as we take this stuff out of the internal repo.
I'm open to making other large scale changes as well.
Another question is where we should be putting this stuff. testing/integration_testing might not be the best place, especially for restore_secrets.py, which should probably go into scripts/