Skip to content

Update release version to 9.3.0 #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Update release version to 9.3.0 #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp_sdk_version.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"released": "9.2.0",
"stable": "9.2.0",
"head": "9.2.0"
"released": "9.3.0",
"stable": "9.3.0",
"head": "9.3.0"
}
2 changes: 1 addition & 1 deletion release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ workflow use only during the development of your app, not for publicly shipping
code.

## Release Notes
### Upcoming Changes
### 9.3.0
- Changes
- General (Android,Linux): Fixed a concurrency bug where waiting for an
event with a timeout could occasionally return prematurely, as if the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't quite this PR, but is the indentation wrong on the following 2 lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is correct. All of the later versions also have similar indentation

9.0.0

  • Changes
    • General (iOS): Firebase C++ on iOS is now built using Xcode 13.3.1.

3 spaces between - and Changes, 4 spaces before subsequent dashes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the lines right below this indented the same? (it looks like they aren't in the GitHub UI)

(the line that reads "timeout had occurred" and the following line, I mean)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still looks consistent to me. 6 spaces of indentation for each line that does not have a hyphen.

You can see the raw value of those lines here if you want:
https://raw.githubusercontent.com/firebase/firebase-cpp-sdk/main/release_build_files/readme.md

Expand Down