Skip to content

Update release version to 9.3.0 #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

Update release version to 9.3.0 #1028

merged 1 commit into from
Jul 19, 2022

Conversation

AlmostMatt
Copy link
Contributor

Description

Updates version number for 9.3.0 release

Testing

No functional change

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AlmostMatt AlmostMatt requested a review from jonsimantov July 18, 2022 16:41
jonsimantov
jonsimantov reviewed Jul 18, 2022
View reviewed changes
release_build_files/readme.md
@@ -634,7 +634,7 @@ workflow use only during the development of your app, not for publicly shipping
code.

## Release Notes
### Upcoming Changes
### 9.3.0
- Changes
- General (Android,Linux): Fixed a concurrency bug where waiting for an
event with a timeout could occasionally return prematurely, as if the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this isn't quite this PR, but is the indentation wrong on the following 2 lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is correct. All of the later versions also have similar indentation

9.0.0

  • Changes
    • General (iOS): Firebase C++ on iOS is now built using Xcode 13.3.1.

3 spaces between - and Changes, 4 spaces before subsequent dashes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the lines right below this indented the same? (it looks like they aren't in the GitHub UI)

(the line that reads "timeout had occurred" and the following line, I mean)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still looks consistent to me. 6 spaces of indentation for each line that does not have a hyphen.

You can see the raw value of those lines here if you want:
https://raw.githubusercontent.com/firebase/firebase-cpp-sdk/main/release_build_files/readme.md

@AlmostMatt AlmostMatt merged commit 912e979 into main Jul 19, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@github-actions
Copy link

github-actions bot commented Jul 19, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @AlmostMatt on commit 912e979
Last updated: Tue Jul 19 11:59 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Windows] [x64] [openssl]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@firebase firebase locked and limited conversation to collaborators Aug 19, 2022
@AlmostMatt AlmostMatt deleted the update-version-930 branch October 20, 2022 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov left review comments

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlmostMatt @jonsimantov @DellaBitta