Skip to content

Change Firestore external ref to one with patch.exe bugfix #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jun 23, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

In the Firestore iOS SDK, the usage of patch.exe crashes on Windows due to CRLF issues. This is fixed in that repo by firebase/firebase-ios-sdk#9941; use that commit in the C++ SDK, since it was not included in the 9.2.0 release. (The commit was branched off of the CocoaPods-9.2.0 tag.)


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running C++ Packaging workflow.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from dconeybe June 23, 2022 21:07
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jun 23, 2022
@dconeybe
Copy link
Contributor

For posterity and cross-referencing, this PR effectively patches in firebase/firebase-ios-sdk#9941 to the cmake builds here in the cpp sdk.

@DellaBitta DellaBitta merged commit 33d2162 into main Jun 24, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2022
@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit 33d2162
Last updated: Fri Jun 24 07:06 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 24, 2022
@firebase firebase locked and limited conversation to collaborators Jul 25, 2022
@jonsimantov jonsimantov deleted the bugfix/windows-patch-exe branch August 8, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants