Trying to fix issue #72 - Targeting Android 28, with Android Studio 3.2.1 #73
Conversation
|
I have not reviewed this for functionality in here, but there's nothing malicious. |
|
/retest |
|
I do find the test failures a bit unexpected. I have tested them all locally and all was good. Is there any way I can do check, smoke-tests-debug, smoke-tests-release locally? |
Fixing firestore-lint problem
- Some deprecated Espresso test also changed.
|
/retest |
1 similar comment
|
/retest |
|
Finally it went through. |
| @@ -98,7 +98,7 @@ class LicenseResolverPlugin implements Plugin<Project> { | |||
|
|
|||
| // must run before preBuild, otherwise it produces an empty license report. | |||
| project.tasks.getByName('preBuild').mustRunAfter licensesTask | |||
| project.tasks.getByName("bundle${variantName}") { | |||
| project.tasks.getByName("bundle${variantName}Aar") { | |||
There was a problem hiding this comment.
@ashwinraghav can you sanity check this?
@iamyaoxi can you explain this change? Is this something to do with the newer gradle plugin?
There was a problem hiding this comment.
Yes. I think it's related to the newer Gradle plugin. I tried to use bundle${variantName} task, it always failing. And I read it's already replaced with bundleAar
There was a problem hiding this comment.
I opened (but already closed) issue #71
The error was: Task with name 'bundleRelease' not found in project ':firebase-common'
| @@ -45,8 +46,8 @@ android { | |||
| } | |||
| } | |||
| compileOptions { | |||
| sourceCompatibility JavaVersion.VERSION_1_8 | |||
| targetCompatibility JavaVersion.VERSION_1_8 | |||
| sourceCompatibility 1.8 | |||
There was a problem hiding this comment.
Any reason not to use JavaVersion constants?
| defaultConfig { | ||
| minSdkVersion 14 | ||
| } | ||
| buildTypes { |
There was a problem hiding this comment.
These lines look a little suspicious:
- Do we need the empty
sourceSets? - Shouldn't the
compileOptionsbe inherited? - I don't think we want
useProguard trueanymore, we're not proguarding these SDKs going forward. Or is that only needed to pass forward theconsumerProguardFiles?
There was a problem hiding this comment.
compileOptionsis not inherited. It always failed when I didn't set it to Java 8.- I only follow pattern of other projects for the use of
useProguard true. So should we remove it, as well in other projects?
...apps/database-test-app/src/main/java/com/google/firebase/testapps/database/TestActivity.java
Outdated
Show resolved
Hide resolved
- Remove useProguard true, as we want to opensource the SDK - Remove empty source sets - Use gradle 4.10.2, to anticipate network error and reduce build time
|
I find it weird for it to fail on something different. Try again. /retest |
firebase-database-collection/firebase-database-collection.gradle
Outdated
Show resolved
Hide resolved
- Test apps are not using Java 8 - firebase-database-collection minSdkVersion revert to 9 - protolite-well-known-types indent & reformat
|
/retest |
Merge with latest updates
|
@iamyaoxi thanks for all the hard work and patience! |
|
Thank you @samtstern and @ashwinraghav I'll do my best to keep on contributing, and hopefully can give more meaningful contributions! :) |
Fixes #72