Skip to content

Migrate to Android 28 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yos1p opened this issue Oct 12, 2018 · 2 comments · Fixed by #73
Closed

Migrate to Android 28 #72

yos1p opened this issue Oct 12, 2018 · 2 comments · Fixed by #73

Comments

@yos1p
Copy link
Contributor

yos1p commented Oct 12, 2018

Since now we have Android 28, with the latest Gradle plugin, why don't we just use the latest dependencies?
@ashwinraghav
Copy link
Contributor

Hey Yosi,
This seems reasonable. Please send us a pull request with the upgrades you have in mind.

@yos1p
Copy link
Contributor Author

yos1p commented Oct 16, 2018

Hi @ashwinraghav
I already made one. It's in the Pull Requests pool. Over there, it's pull requests #73

@yos1p yos1p mentioned this issue Oct 17, 2018
Merged
ashwinraghav pushed a commit that referenced this issue Oct 29, 2018
@yos1p @ashwinraghav
Trying to fix issue #72 - Targeting Android 28, with Android Studio 3…
8ccb305 
….2.1
@saurabhdtu saurabhdtu mentioned this issue Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trying to fix issue #72 - Targeting Android 28, with Android Studio 3.2.1
2 participants
@ashwinraghav @yos1p