Migrate to Firebase common executors #6128

mrober · 2024-07-26T18:29:45Z

Migrate to Firebase common executors. Use the new CrashlyticsWorker for common and disk write workers.

github-actions · 2024-07-26T18:29:58Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

github-actions · 2024-07-26T18:29:58Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2024-07-26T18:35:52Z

Coverage Report ¹

Affected Products

`firebase-crashlytics`

Overall coverage changed from 11.22% (705d7a3) to 11.14% (2283635) by -0.09%.

Filename	Base (`705d7a3`)	Merge (`2283635`)	Diff
CrashlyticsBackgroundWorker.java	56.25%	0.00%	-56.25%
CrashlyticsController.java	16.10%	16.06%	-0.04%
CrashlyticsCore.java	0.61%	0.63%	+0.02%
CrashlyticsWorker.java	0.00%	37.04%	+37.04%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/I3bHZMfIDO.html

github-actions · 2024-07-26T18:46:07Z

Unit Test Results

  8 files ±0   8 suites ±0 25s ⏱️ -3s
22 tests ±0 22 ✔️ ±0 0 💤 ±0 0 ❌ ±0
44 runs ±0 44 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 103a721. ± Comparison against base commit 705d7a3.

♻️ This comment has been updated with latest results.

google-oss-bot · 2024-07-26T18:46:26Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (705d7a3) Merge (2283635) Diff
aar 419 kB 416 kB -2.50 kB (-0.6%)
apk (aggressive) 695 kB 697 kB +1.70 kB (+0.2%)
apk (release) 5.85 MB 5.85 MB -304 B (-0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/XhFfRuLXHJ.html

...ytics/src/androidTest/java/com/google/firebase/crashlytics/internal/CrashlyticsTestCase.java

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCore.java

...rc/androidTest/java/com/google/firebase/crashlytics/internal/metadata/MetaDataStoreTest.java

google-oss-bot · 2024-07-26T19:44:19Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (705d7a3) and the CI merge commit (2283635)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 705d7a3: https://storage.googleapis.com/firebase-sdk-metric-reports/gSVvshB23I/index.html
- 2283635: https://storage.googleapis.com/firebase-sdk-metric-reports/sK9oORuIBY/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	12.3 ±3 ms	11.0 ±2 ms	-1.29 ms (-10.5%)	NO
p25	13.0 ±3 ms	11.6 ±2 ms	-1.40 ms (-10.8%)	NO
p50	14.1 ±3 ms	12.7 ±3 ms	-1.48 ms (-10.5%)	NO
p75	15.3 ±4 ms	14.4 ±3 ms	-973 μs (-6.3%)	NO
p90	17.0 ±4 ms	16.3 ±4 ms	-706 μs (-4.2%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

redfin-30

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	15.1 ±6 ms	16.4 ±7 ms	+1.29 ms (+8.5%)	NO
p25	15.9 ±6 ms	17.3 ±7 ms	+1.36 ms (+8.5%)	NO
p50	16.9 ±7 ms	18.8 ±9 ms	+1.88 ms (+11.1%)	NO
p75	18.1 ±8 ms	20.7 ±9.7 ms	+2.54 ms (+14.0%)	NO
p90	20.0 ±9 ms	23.0 ±10 ms	+3.04 ms (+15.2%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	585 ±603 μs	248 ±530 μs	-337 μs (-57.6%)	NO
p25	611 ±619 μs	262 ±560 μs	-349 μs (-57.1%)	NO
p50	648 ±654 μs	276 ±584 μs	-372 μs (-57.4%)	NO
p75	713 ±709 μs	309 ±645 μs	-404 μs (-56.6%)	NO
p90	832 ±813 μs	385 ±780 μs	-447 μs (-53.7%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

redfin-30

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	573 ±659 μs	400 ±402 μs	-173 μs (-30.2%)	NO
p25	632 ±728 μs	456 ±463 μs	-176 μs (-27.9%)	NO
p50	751 ±871 μs	563 ±570 μs	-188 μs (-25.0%)	NO
p75	902 ±1039 μs	722 ±725 μs	-180 μs (-19.9%)	NO
p90	1.18 ±1 ms	963 ±973 μs	-219 μs (-18.5%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	3.03 ±0.8 ms	3.28 ±0.9 ms	+250 μs (+8.3%)	NO
p25	3.21 ±0.9 ms	3.47 ±0.9 ms	+256 μs (+8.0%)	NO
p50	3.60 ±0.9 ms	3.81 ±1 ms	+208 μs (+5.8%)	NO
p75	4.16 ±0.9 ms	4.36 ±1 ms	+199 μs (+4.8%)	NO
p90	4.88 ±0.9 ms	5.10 ±1 ms	+220 μs (+4.5%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

redfin-30

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	6.24 ±2 ms	5.86 ±1 ms	-377 μs (-6.0%)	NO
p25	6.85 ±2 ms	6.26 ±2 ms	-596 μs (-8.7%)	NO
p50	7.61 ±3 ms	7.00 ±3 ms	-604 μs (-7.9%)	NO
p75	8.70 ±4 ms	7.67 ±4 ms	-1.04 ms (-11.9%)	NO
p90	9.87 ±5 ms	8.61 ±5 ms	-1.26 ms (-12.7%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	204 ±3 ms	206 ±3 ms	+1.96 ms (+1.0%)	NO
p25	210 ±3 ms	212 ±3 ms	+1.49 ms (+0.7%)	NO
p50	218 ±4 ms	219 ±4 ms	+1.21 ms (+0.6%)	NO
p75	225 ±4 ms	227 ±5 ms	+1.89 ms (+0.8%)	NO
p90	234 ±4 ms	237 ±6 ms	+2.75 ms (+1.2%)	NO

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

redfin-30

Percentile	`705d7a3`	`2283635`	Diff	Significant (?)
p10	244 ±4 ms	267 ±6 ms	+22.6 ms (+9.3%)	MAYBE
p25	250 ±5 ms	272 ±6 ms	+22.4 ms (+9.0%)	MAYBE
p50	256 ±5 ms	280 ±6 ms	+23.3 ms (+9.1%)	MAYBE
p75	264 ±6 ms	289 ±8 ms	+25.5 ms (+9.7%)	MAYBE
p90	274 ±6 ms	302 ±8 ms	+28.5 ms (+10.4%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`705d7a3`	2024-07-26_16:16:25.462741_OuqL 2024-07-26_16:16:25.462784_zOsS 2024-07-26_16:16:25.462795_aguI 2024-07-26_16:16:25.462804_cXGA 2024-07-26_16:16:25.462812_mjZI 2024-07-26_16:16:25.462820_prYZ 2024-07-26_16:16:25.462828_YoVl 2024-07-26_16:16:25.462836_nTUB 2024-07-26_16:16:25.462843_KeDd 2024-07-26_16:16:25.462850_eUAo
`2283635`	2024-07-29_16:28:11.049043_JmSh 2024-07-29_16:28:11.049085_WJid 2024-07-29_16:28:11.049094_Iais 2024-07-29_16:28:11.049102_ifFo 2024-07-29_16:28:11.049109_gLvx 2024-07-29_16:28:11.049117_VFHa 2024-07-29_16:28:11.049124_PvXG 2024-07-29_16:28:11.049131_Vepn 2024-07-29_16:28:11.049137_QOUZ 2024-07-29_16:28:11.049144_KyCL

https://storage.googleapis.com/firebase-sdk-metric-reports/4dclDWXJtA/index.html

This reverts commit 9eda4b2.

...tics/src/main/java/com/google/firebase/crashlytics/internal/settings/SettingsController.java

mrober · 2024-07-29T16:29:45Z

#4345

This reverts commit 96b702f.

Migrate to Firebase common executors

204e7ab

mrober added the no-changelog label Jul 26, 2024

mrober requested a review from themiswang July 26, 2024 18:29

google-oss-bot added the do-not-merge/work-in-progress label Jul 26, 2024

google-oss-bot added the size/L label Jul 26, 2024

Format

98b679d

Format 2

d9cc5d1

themiswang reviewed Jul 26, 2024

View reviewed changes

...ytics/src/androidTest/java/com/google/firebase/crashlytics/internal/CrashlyticsTestCase.java Outdated Show resolved Hide resolved

themiswang reviewed Jul 26, 2024

View reviewed changes

...ashlytics/src/main/java/com/google/firebase/crashlytics/internal/common/CrashlyticsCore.java Show resolved Hide resolved

Fix tests that failed in test lab

9eda4b2

themiswang reviewed Jul 26, 2024

View reviewed changes

...rc/androidTest/java/com/google/firebase/crashlytics/internal/metadata/MetaDataStoreTest.java Show resolved Hide resolved

mrober added 2 commits July 29, 2024 12:07

Revert "Fix tests that failed in test lab"

0eaa4b4

This reverts commit 9eda4b2.

Copy test from @themiswang ##6120 to make merging easier

f0f05a8

google-oss-bot added size/XL and removed size/L labels Jul 29, 2024

We aren't going to do that

103a721

mrober requested a review from themiswang July 29, 2024 16:15

themiswang reviewed Jul 29, 2024

View reviewed changes

...tics/src/main/java/com/google/firebase/crashlytics/internal/settings/SettingsController.java Show resolved Hide resolved

themiswang approved these changes Jul 29, 2024

View reviewed changes

themiswang marked this pull request as ready for review July 29, 2024 16:24

mrober added main-merge-ack and removed do-not-merge/work-in-progress labels Jul 29, 2024

mrober changed the title ~~WIP: Migrate to Firebase common executors~~ Migrate to Firebase common executors Jul 29, 2024

mrober merged commit 96b702f into main Jul 29, 2024
43 of 44 checks passed

mrober deleted the crashlytics-worker branch July 29, 2024 16:30

mrober added a commit that referenced this pull request Aug 19, 2024

Revert "Migrate to Firebase common executors (#6128)"

da03580

This reverts commit 96b702f.

firebase locked and limited conversation to collaborators Aug 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate to Firebase common executors #6128

Migrate to Firebase common executors #6128

Uh oh!

mrober commented Jul 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jul 26, 2024

Uh oh!

google-oss-bot commented Jul 26, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

github-actions bot commented Jul 26, 2024 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 26, 2024 •

edited

Loading

`firebase-crashlytics`

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Jul 26, 2024 •

edited

Loading

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

Uh oh!

mrober commented Jul 29, 2024

Uh oh!

Uh oh!

Uh oh!

Migrate to Firebase common executors #6128

Migrate to Firebase common executors #6128

Uh oh!

Conversation

mrober commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

github-actions bot commented Jul 26, 2024

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

github-actions bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-crashlytics

Test Logs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

Uh oh!

Uh oh!

mrober commented Jul 29, 2024

Uh oh!

Uh oh!

Uh oh!

mrober commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

google-oss-bot commented Jul 26, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

github-actions bot commented Jul 26, 2024 •

edited

Loading

google-oss-bot commented Jul 26, 2024 •

edited

Loading

Size Report ¹

`firebase-crashlytics`

google-oss-bot commented Jul 26, 2024 •

edited

Loading

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`