Skip to content

Commit 705d7a3

Browse files
authored
Generalize the CrashlyticsWorker (#6126)
Generalize the CrashlyticsWorker. The old CrashlyticsBackgroundWorker has a lot of overhead. Local experimentation shows this generalized worker manages submitting tasks about 4 times as fast. The old background worker has some inaccurate Javadoc. I corrected and verified every detail mentioned in the Javadoc with integration tests. We can rely on it now. I also found a bug in the old worker. If you cancel a task then submit a runnable or callable, that will never execute because the chain breaks. I fixed it in the general worker and added test cases. Next steps will be to utilize the generic worker for the proposed common, network, and disk write workers.
1 parent 0b026b2 commit 705d7a3

File tree

4 files changed

+563
-0
lines changed

4 files changed

+563
-0
lines changed

firebase-crashlytics/firebase-crashlytics.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,4 +111,6 @@ dependencies {
111111
androidTestImplementation(libs.androidx.test.junit)
112112
androidTestImplementation(libs.androidx.test.runner)
113113
androidTestImplementation(libs.truth)
114+
androidTestImplementation(libs.playservices.tasks)
115+
androidTestImplementation(project(":integ-testing"))
114116
}

0 commit comments

Comments
 (0)