Generalize the CrashlyticsWorker #6126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (44fdfb9) and the base commit (0b026b2) are not available. No macrobenchmark data found for the base commit (0b026b2). Analysis for the CI merge commit (44fdfb9) can be found at: |
themiswang
approved these changes
Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize the CrashlyticsWorker.
The old CrashlyticsBackgroundWorker has a lot of overhead. Local experimentation shows this generalized worker manages submitting tasks about 4 times as fast.
The old background worker has some inaccurate Javadoc. I corrected and verified every detail mentioned in the Javadoc with integration tests. We can rely on it now.
I also found a bug in the old worker. If you cancel a task then submit a runnable or callable, that will never execute because the chain breaks. I fixed it in the general worker and added test cases.
Next steps will be to utilize the generic worker for the proposed common, network, and disk write workers.