Removed unused Android Lifecycle dependencies #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test smoke-tests-release |
This commit actually remove them instead of commenting them out. These dependencies cause a breakage for binary size tooling and appear to be unused.
|
/retest |
bjornick
reviewed
Oct 4, 2018
This merges in the last release bump.
|
/test check |
|
@bjornick Do you want to run it against the actual quickstart apps? Or the smoke test apps in the repo? This is passing with the smoke tests. |
bjornick
approved these changes
Oct 5, 2018
davidmotson
pushed a commit
that referenced
this pull request
Nov 1, 2018
This reverts commit 5e25b96.
davidmotson
pushed a commit
that referenced
this pull request
Nov 1, 2018
This reverts commit 8218c56.
davidmotson
added a commit
that referenced
this pull request
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the android.arch.lifecycle:runtime:1.1.1, android.arch.lifecycle:common:1.1.1, android.arch.core:runtime:1.1.1, and android.arch.core:common:1.1.1 dependencies from Database, Firestore, and Storage.
Are these dependencies needed for some hidden reason? The tests pass with these removed, and their presence is causing some build errors for our APK size measurement tooling.