Skip to content

Commit 5e25b96

Browse files
authored
Removed unused Android Lifecycle dependencies (#55)
Removed unused Android Lifecycle dependencies These dependencies break the size tooling and are in fact unused by Database, Firestore, and Storage.
1 parent df85231 commit 5e25b96

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

firebase-database/firebase-database.gradle

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,6 @@ dependencies {
8484
implementation "com.google.android.gms:play-services-basement:$playServicesVersion"
8585
implementation "com.google.android.gms:play-services-base:$playServicesVersion"
8686
implementation "com.google.android.gms:play-services-tasks:$playServicesVersion"
87-
implementation 'android.arch.lifecycle:runtime:1.1.1'
88-
implementation "android.arch.lifecycle:common:1.1.1"
89-
implementation "android.arch.core:runtime:1.1.1"
90-
implementation "android.arch.core:common:1.1.1"
9187

9288
androidTestImplementation "com.android.support:support-annotations:$supportAnnotationsVersion"
9389
androidTestImplementation 'com.android.support.test:rules:1.0.2'
@@ -115,4 +111,4 @@ dependencies {
115111
// androidTest integration tests.
116112
// ==========================================================================
117113
ext.packageName = "com.google.firebase.database"
118-
apply from: '../gradle/googleServices.gradle'
114+
apply from: '../gradle/googleServices.gradle'

firebase-firestore/firebase-firestore.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,6 @@ dependencies {
106106
exclude group: "com.google.firebase", module: "firebase-common"
107107
}
108108

109-
implementation 'android.arch.lifecycle:runtime:1.1.1'
110-
implementation 'android.arch.lifecycle:common:1.1.1'
111-
112109
testCompile 'junit:junit:4.11'
113110
testCompile 'org.mockito:mockito-core:1.10.19'
114111
testCompile 'org.robolectric:robolectric:4.0-alpha-3'

firebase-storage/firebase-storage.gradle

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ dependencies {
8080

8181
implementation "com.google.android.gms:play-services-base:$playServicesVersion"
8282
implementation "com.google.android.gms:play-services-tasks:$playServicesVersion"
83-
implementation 'android.arch.lifecycle:runtime:1.1.1'
84-
implementation "android.arch.lifecycle:common:1.1.1"
85-
implementation "android.arch.core:runtime:1.1.1"
86-
implementation "android.arch.core:common:1.1.1"
8783

8884
androidTestImplementation "com.android.support:support-annotations:$supportAnnotationsVersion"
8985
androidTestImplementation 'com.android.support.test:rules:1.0.2'
@@ -94,4 +90,4 @@ dependencies {
9490
testImplementation 'junit:junit:4.12'
9591
testImplementation 'org.mockito:mockito-core:2.18.3'
9692
testImplementation 'org.robolectric:robolectric:4.0-alpha-3-SNAPSHOT'
97-
}
93+
}

0 commit comments

Comments
 (0)