Skip to content

Held Write Acks Changelog entries #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Held Write Acks Changelog entries #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions firebase-firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
# Unreleased
- [changed] Changed the internal handling for locally updated documents that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. This tells me that there's a "slight behavior change" but doesn't say what that is... (though does say it may affect the metadata flag). But I see that's what we've got for the web port. Is this worth expanding on at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty much impossible to put into words, so we decided to be vague about it.

haven't yet been read back from Cloud Firestore. This can lead to slight
behavior changes and may affect the `SnapshotMetadata.hasPendingWrites()`
metadata flag.
- [changed] Eliminated superfluous update events for locally cached documents
that are known to lag behind the server version. Instead, we buffer these
events until the client has caught up with the server.

# 17.1.1
- [fixed] Fixed an issue where the first `get()` call made after being offline
could incorrectly return cached data without attempting to reach the backend.
Expand Down