Held Write Acks Changelog entries #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test connected-check |
|
@schmidt-sebastian: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rsgowman
approved these changes
Oct 3, 2018
| @@ -1,3 +1,12 @@ | |||
| # Unreleased | |||
| - [changed] Changed the internal handling for locally updated documents that | |||
There was a problem hiding this comment.
Hm. This tells me that there's a "slight behavior change" but doesn't say what that is... (though does say it may affect the metadata flag). But I see that's what we've got for the web port. Is this worth expanding on at all?
There was a problem hiding this comment.
It's pretty much impossible to put into words, so we decided to be vague about it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://firebase.google.com/support/release-notes/js