Skip to content

Update FTL default device to pixel7 api 33 #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Update FTL default device to pixel7 api 33 #5289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c4bfe1
Update FTL default device to pixel7 api 33
rlazo Aug 31, 2023
75508b9
Update crashlytics and transport runtime too.
rlazo Aug 31, 2023
6510f67
Merge branch 'master' into rl.ftl.api33
rlazo Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ https://firebase.google.com.
* Import the firebase-android-sdk gradle project into Android Studio using the
**Import project(Gradle, Eclipse ADT, etc.)** option.
* `firebase-crashlytics-ndk` must be built with NDK 21. See
[firebase-crashlytics-ndk](firebase-crashlytics-ndk/README.md) for more
[firebase-crashlytics-ndk](firebase-crashlytics-ndk/README.md) for more
details.

## Testing
Expand Down Expand Up @@ -143,7 +143,7 @@ Integration tests can be executed on the command line by running
```

This will execute tests on devices that are configured per project, if nothing is configured for the
project, the tests will run on `model=Pixel2,version=27,locale=en,orientation=portrait`.
project, the tests will run on `model=panther,version=33,locale=en,orientation=portrait`.

Projects can be configured in the following way:

Expand Down
2 changes: 1 addition & 1 deletion .../src/main/java/com/google/firebase/gradle/plugins/ci/device/FirebaseTestLabExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void timeout(String timeout) {

Set<String> getDevices() {
if (devices.get().isEmpty()) {
return Collections.singleton("model=Pixel2,version=27,locale=en,orientation=portrait");
return Collections.singleton("model=panther,version=33,locale=en,orientation=portrait");
}
return devices.get();
}
Expand Down
2 changes: 1 addition & 1 deletion firebase-config/bandwagoner/bandwagoner.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ android {
}

firebaseTestLab {
device 'model=Pixel2,version=28,locale=en,orientation=portrait'
device 'model=panther,version=33,locale=en,orientation=portrait'
}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion firebase-crashlytics/firebase-crashlytics.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ firebaseLibrary {
libraryGroup "crashlytics"
testLab {
enabled = true
device 'model=redfin,version=30'
device 'model=panther,version=33'
}
}

Expand Down
10 changes: 3 additions & 7 deletions transport/transport-runtime/transport-runtime.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,9 @@ firebaseLibrary {
testLab {
enabled = true

device 'model=blueline,version=28' // Pixel3
device 'model=walleye,version=27' // Pixel2
device 'model=Nexus4,version=22'
device 'model=Nexus7,version=21'
device 'model=Nexus4,version=19'
device 'model=starqlteue,version=26' // Galaxy S9
device 'model=harpia,version=23' // Moto G Play
device 'model=panther,version=33' // Pixel7
device 'model=redfin,version=30' // Pixel5
device 'model=x1q,version=29'
}
}

Expand Down