Skip to content

Update FTL default device to pixel7 api 33 #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2023
Merged

Update FTL default device to pixel7 api 33 #5289

merged 3 commits into from
Aug 31, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Aug 31, 2023

No description provided.

@rlazo rlazo requested review from daymxn and emilypgoogle August 31, 2023 15:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@rlazo rlazo enabled auto-merge (squash) August 31, 2023 15:28
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

buildSrc Test Results

33 tests   33 ✔️  1m 37s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit 6510f67.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

Unit Test Results

   820 files  +   814     820 suites  +814   37m 28s ⏱️ + 37m 9s
5 005 tests +4 987  4 983 ✔️ +4 965  21 💤 +21  1 ❌ +1 
9 919 runs  +9 883  9 876 ✔️ +9 840  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 6510f67. ± Comparison against base commit b76de4f.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 31, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (b76de4f) and merge commit (2fb90a0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Z5heWSqkEr.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 31, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.12% (b76de4f) to 50.18% (2fb90a0) by +0.05%.

    FilenameBase (b76de4f)Merge (2fb90a0)Diff
    DoubleNode.java88.24%100.00%+11.76%
    QueryParams.java90.36%89.76%-0.60%
    WebsocketConnection.java32.77%35.03%+2.26%

  • firebase-firestore

    Overall coverage changed from 44.63% (b76de4f) to 44.64% (2fb90a0) by +0.00%.

    FilenameBase (b76de4f)Merge (2fb90a0)Diff
    SetMutation.java94.44%97.22%+2.78%

  • firebase-messaging

    Overall coverage changed from 84.10% (b76de4f) to 84.18% (2fb90a0) by +0.08%.

    FilenameBase (b76de4f)Merge (2fb90a0)Diff
    MessagingAnalytics.java81.78%81.38%-0.40%
    Metadata.java36.51%41.27%+4.76%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/T4ymE5xEaB.html

@rlazo rlazo merged commit de35ba0 into master Aug 31, 2023
@rlazo rlazo deleted the rl.ftl.api33 branch August 31, 2023 18:09
limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
@rlazo @limsaehyun
Update FTL default device to pixel7 api 33 (firebase#5289)
270ffcf
@firebase firebase locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @emilypgoogle