Update semver tests and the pom validator tests to handle new sdk #5133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
VinayGuthal
changed the title
Generated by 🚫 Danger |
Size Report 1Affected Products
Test Logs |
daymxn
approved these changes
Jul 5, 2023
| @@ -43,10 +43,15 @@ abstract class PomValidator : DefaultTask() { | |||
|
|
|||
| @TaskAction | |||
| fun run() { | |||
| var diff = diffWithPomFromURL(getLatestReleasePomUrl()) | |||
| try { | |||
| var diff = diffWithPomFromURL(getLatestReleasePomUrl()) | |||
There was a problem hiding this comment.
I realize I accidentally left this as var- this should probably be changed to val
|
|
||
| from(project.zipTree("semver/previous.aar")) | ||
| into(project.file("semver/previous-version")) | ||
| if (project.file("semver/previous.aar").exists()) { |
There was a problem hiding this comment.
Keep in mind that if this file is added by any task- this will fail. This check will occur at configuration time, not execution time.
| try { | ||
| URL(gMavenPath).openStream().use { Files.copy(it, Paths.get(filePath.get())) } | ||
| } catch (_: java.io.FileNotFoundException) { | ||
| // Gmaven Artifact doesn't exist. |
There was a problem hiding this comment.
You should be fine to replace these empty returns with StopActionException for more information.
throw StopActionException("GMaven artifact doesn't exist")
Coverage Report 1Affected Products
Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.