Firestore: removed unused compareTo() computation (#5132)

dconeybe · web-flow · commit 1e442570e205 · 2023-07-05T12:26:04.000-04:00
diff --git a/firebase-firestore/src/main/java/com/google/firebase/firestore/core/View.java b/firebase-firestore/src/main/java/com/google/firebase/firestore/core/View.java
@@ -287,7 +287,6 @@ public ViewChange applyChanges(DocumentChanges docChanges, TargetChange targetCh
         viewChanges,
         (DocumentViewChange o1, DocumentViewChange o2) -> {
           int typeComp = compareIntegers(View.changeTypeOrder(o1), View.changeTypeOrder(o2));
-          o1.getType().compareTo(o2.getType());
           if (typeComp != 0) {
             return typeComp;
           }

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,6 @@ public ViewChange applyChanges(DocumentChanges docChanges, TargetChange targetCh`
`287`	`287`	`viewChanges,`
`288`	`288`	`(DocumentViewChange o1, DocumentViewChange o2) -> {`
`289`	`289`	`int typeComp = compareIntegers(View.changeTypeOrder(o1), View.changeTypeOrder(o2));`
`290`		`- o1.getType().compareTo(o2.getType());`
`291`	`290`	`if (typeComp != 0) {`
`292`	`291`	`return typeComp;`
`293`	`292`	`}`