Firestore Spec Tests: Port JS PR 7257 (use strings for targetPurpose)
#4931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… readTime and resumeToken into a data structure)
…ocal cache sync when resuming a query that had docs deleted)
…dkPr7021' into SpecTestPortJsSdkPr7229_PR4929
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected ProductsNo changes between base commit (84894be) and merge commit (c109641).Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (c109641) and the base commit (84894be) are not available. No macrobenchmark data found for the base commit (84894be). Analysis for the CI merge commit (c109641) can be found at: |
…dkPr7229' into SpecTestPortJsSdkPr7257_PR4931
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port spec test changes from firebase/firebase-js-sdk#7257 (Firestore: use string values for TargetPurpose enum).
For reference, here is the iOS port of the same change: firebase/firebase-ios-sdk#11191