Firestore spec tests: Bundle the readTime and resumeToken into a data structure #7021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passing them around individually
|
Size Report 1Affected ProductsNo changes between base commit (fa0a7c0) and merge commit (46f4a2e).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (fa0a7c0) and merge commit (46f4a2e).Test Logs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor in the spec tests in the test runner logic. Previously, it "passed around" resume token and read time objects individually. This PR groups them together into a single data structure,
ResumeSpec. This cleans up the code a bit and also poises it for naturally handing changes in an upcoming PR.Credit for this PR goes to @milaGGL from #6839. I'm merely merging a small component of that PR into the master branch to reduce the diff when her PR ultimately gets merged.
Android port: firebase/firebase-android-sdk#4928
iOS Port: firebase/firebase-ios-sdk#11183