Skip to content

Update test app. #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2022
Merged

Update test app. #3655

merged 1 commit into from
Apr 15, 2022

Conversation

rosalyntan
Copy link
Member

No description provided.

@rosalyntan rosalyntan requested a review from malcolmdeck April 14, 2022 23:00
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (c32c180) and merge commit (a243f1e).

Test Logs

Notes

  • Commit (a243f1e) is created by Prow via merging PR base commit (c32c180) and head commit (84b8794).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZP5ApapvzN.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (c32c180) and merge commit (a243f1e).

Test Logs

Notes

  • Commit (a243f1e) is created by Prow via merging PR base commit (c32c180) and head commit (84b8794).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RgQceI8tP0.html

malcolmdeck
malcolmdeck approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@malcolmdeck malcolmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rosalyntan rosalyntan merged commit ae07804 into play-integrity Apr 15, 2022
@rosalyntan rosalyntan deleted the rosalyntan.playtest branch April 15, 2022 17:46
rosalyntan added a commit that referenced this pull request Apr 19, 2022
@rosalyntan
Add Play Integrity support to App Check (#3658)
20da1e7 
* Initial App Check <> Play Integrity commit (#3607)

* Initial commit of App Check Play Integrity files.

* Added skeleton code for PlayIntegrityAppCheckProviderFactory and PlayIntegrityAppCheckProvider.

* Set version in gradle.properties to 16.0.0-beta01 for now.

* Updated wrong gradle.properties file in last commit.

* Implement Play Integrity token exchange. (#3613)

* Implement Play Integrity exchange.

* Update and add unit tests.

* Add @nonnull annotation.

* Implement Play Integrity attestation flow. (#3618)

* Add method to call the `GeneratePlayIntegrityChallenge` endpoint to `NetworkClient`.

* Implement Play Integrity attestation flow.

* Add project number to IntegrityTokenRequest.

* Fix `PlayIntegrityAppCheckProviderTest`s.

* Add unit tests.

* Address review comments.

* Update test app. (#3655)

* Update version in `gradle.properties`.

* Fix tests broken after merge.

* Address review comments.

* Address review comment.
@firebase firebase locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malcolmdeck malcolmdeck malcolmdeck approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosalyntan @google-oss-bot @malcolmdeck