Skip to content

Initial App Check <> Play Integrity commit #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2022
Merged

Initial App Check <> Play Integrity commit #3607

merged 4 commits into from
Apr 1, 2022

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Mar 31, 2022 •
edited
Loading

Initial commit of skeleton code for new App Check Play Integrity SDK.

The public API has been approved in go/fac-pia-api.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-common:
error: Added method com.google.firebase.FirebaseApp.getApplicationContext() [AddedMethod]

The public api surface has changed for the subproject firebase-annotations:
error: Removed class com.google.firebase.annotations.PreviewApi1 [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@VinayGuthal
Copy link
Contributor

/test api-information

@rosalyntan rosalyntan marked this pull request as ready for review March 31, 2022 20:26
@rosalyntan
Copy link
Member Author

/retest

@rosalyntan
Copy link
Member Author

/test device-check-changed

vkryachko
vkryachko approved these changes Mar 31, 2022
View reviewed changes
@rosalyntan
Copy link
Member Author

/test device-check-changed

@rosalyntan rosalyntan merged commit cf98935 into play-integrity Apr 1, 2022
@rosalyntan rosalyntan deleted the rosalyntan.initial branch April 1, 2022 21:53
@google-oss-bot
Copy link
Contributor

@rosalyntan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed c639f34 link /test check-changed
device-check-changed c639f34 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rosalyntan added a commit that referenced this pull request Apr 19, 2022
@rosalyntan
Add Play Integrity support to App Check (#3658)
20da1e7 
* Initial App Check <> Play Integrity commit (#3607)

* Initial commit of App Check Play Integrity files.

* Added skeleton code for PlayIntegrityAppCheckProviderFactory and PlayIntegrityAppCheckProvider.

* Set version in gradle.properties to 16.0.0-beta01 for now.

* Updated wrong gradle.properties file in last commit.

* Implement Play Integrity token exchange. (#3613)

* Implement Play Integrity exchange.

* Update and add unit tests.

* Add @nonnull annotation.

* Implement Play Integrity attestation flow. (#3618)

* Add method to call the `GeneratePlayIntegrityChallenge` endpoint to `NetworkClient`.

* Implement Play Integrity attestation flow.

* Add project number to IntegrityTokenRequest.

* Fix `PlayIntegrityAppCheckProviderTest`s.

* Add unit tests.

* Address review comments.

* Update test app. (#3655)

* Update version in `gradle.properties`.

* Fix tests broken after merge.

* Address review comments.

* Address review comment.
@firebase firebase locked and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@malcolmdeck malcolmdeck malcolmdeck approved these changes

@weixifan weixifan Awaiting requested review from weixifan

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosalyntan @google-oss-bot @VinayGuthal @vkryachko @malcolmdeck