Edit java docs for Firebase App Distribution #3393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected ProductsNo changes between base commit (bce1a75) and merge commit (3904713).Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
lfkellogg
reviewed
Feb 2, 2022
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/BinaryType.java
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateProgress.java
Outdated
Show resolved
Hide resolved
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateProgress.java
Outdated
Show resolved
Hide resolved
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateTask.java
Outdated
Show resolved
Hide resolved
lfkellogg
approved these changes
Feb 3, 2022
...ppdistribution/src/main/java/com/google/firebase/appdistribution/AppDistributionRelease.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
...pdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java
Outdated
Show resolved
Hide resolved
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateProgress.java
Outdated
Show resolved
Hide resolved
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateProgress.java
Outdated
Show resolved
Hide resolved
firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateTask.java
Outdated
Show resolved
Hide resolved
manny-jimenez
approved these changes
Feb 3, 2022
lfkellogg
reviewed
Feb 3, 2022
| * release is available. | ||
| * The number of bytes downloaded so far for an APK. | ||
| * | ||
| * @returns the number of bytes downloaded, or -1 if called when updating to an AAB or if no new |
There was a problem hiding this comment.
Oh, and this should be @return not @returns
| * release is available. | ||
| * The file size of the APK file to download in bytes. | ||
| * | ||
| * @returns the file size in bytes, or -1 if called when updating to an AAB or if no new release |
There was a problem hiding this comment.
Oh, and this should be @return not @returns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Java doc comments based on code review feedback on the auto generated java docs.
Once this merges into the main branch, the test release branch will automatically re-generate the zip file with the docs.