Skip to content

Commit 0de60ad

Browse files
author
Rachel Prince
committed
Responding to PR feedback
1 parent 6e82316 commit 0de60ad

File tree

4 files changed

+15
-12
lines changed

4 files changed

+15
-12
lines changed

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/AppDistributionRelease.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
import com.google.auto.value.AutoValue;
2020

2121
/**
22-
* The release information returned by {@link checkForNewRelease} when a new version is available
23-
* for the signed in tester.
22+
* The release information returned by {@link FirebaseAppDistribution#checkForNewRelease} when a new
23+
* version is available for the signed in tester.
2424
*/
2525
@AutoValue
2626
public abstract class AppDistributionRelease {

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/FirebaseAppDistribution.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ public Task<Void> signInTester() {
258258

259259
/**
260260
* Returns an {@link AppDistributionRelease} if an update is available for the current signed in
261-
* tester or {@code null} otherwise.
261+
* tester, or {@code null} otherwise.
262262
*/
263263
@NonNull
264264
public synchronized Task<AppDistributionRelease> checkForNewRelease() {
@@ -291,9 +291,10 @@ public synchronized Task<AppDistributionRelease> checkForNewRelease() {
291291
}
292292

293293
/**
294-
* Updates app to the {@link AppDistributionRelease} returned by {@link #checkForNewRelease}. If
295-
* the newest release is an APK, downloads the binary and starts an installation. If the newest
296-
* release is an AAB, directs the tester to the Play app to complete the download and
294+
* Updates app to the {@link AppDistributionRelease} returned by {@link #checkForNewRelease}.
295+
*
296+
* <p>If the newest release is an APK, downloads the binary and starts an installation. If the
297+
* newest release is an AAB, directs the tester to the Play app to complete the download and
297298
* installation.
298299
*
299300
* <p>Cancels task with {@link Status#UPDATE_NOT_AVAILABLE} if no new release is cached from

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateProgress.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,17 @@ static UpdateProgress.Builder builder() {
3030
/**
3131
* The number of bytes downloaded so far for an APK.
3232
*
33-
* @returns -1 if called when updating to an AAB or if no new release is available.
33+
* @returns the number of bytes downloaded, or -1 if called when updating to an AAB or if no new
34+
* release is available.
3435
*/
3536
@NonNull
3637
public abstract long getApkBytesDownloaded();
3738

3839
/**
3940
* The file size of the APK file to download in bytes.
4041
*
41-
* @returns -1 if called when updating to an AAB or if no new release is available.
42+
* @returns the file size in bytes, or -1 if called when updating to an AAB or if no new release
43+
* is available.
4244
*/
4345
@NonNull
4446
public abstract long getApkFileTotalBytes();

firebase-appdistribution/src/main/java/com/google/firebase/appdistribution/UpdateTask.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@
2626
*/
2727
public abstract class UpdateTask extends Task<Void> {
2828
/**
29-
* Adds a listener that is called periodically while the UpdateTask executes.
29+
* Adds a listener that is called periodically while this {@link UpdateTask} executes.
3030
*
31-
* @return this Task
31+
* @return this {@link UpdateTask}
3232
*/
3333
@NonNull
3434
public abstract UpdateTask addOnProgressListener(@NonNull OnProgressListener listener);
3535

3636
/**
37-
* Adds a listener that is called periodically while the UpdateTask executes.
37+
* Adds a listener that is called periodically while {@link UpdateTask} executes.
3838
*
3939
* @param executor the executor to use to call the listener
40-
* @return this Task
40+
* @return this {@link UpdateTask}
4141
*/
4242
@NonNull
4343
public abstract UpdateTask addOnProgressListener(

0 commit comments

Comments
 (0)