Adds emulator launch/shutdown capabilities. #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emulator logs are stored in artifacts under test_emulator/ subdirectory.
vkryachko
force-pushed
the
vk.ci
branch
2 times, most recently
from
0bcf102 to
1b2acee
Compare
|
/test connected-check |
ashwinraghav
approved these changes
Sep 21, 2018
davidair
reviewed
Sep 21, 2018
| def __enter__(self): | ||
| _logger.debug('Pretend to start the emulator(TODO)') | ||
| _logger.info('Starting avd "{}..."'.format(self._name)) |
There was a problem hiding this comment.
nit: the double quotes should probably not encompass ellipsis. Currently, this will look like this:
Starting avd "test...", while we'd probably want Starting avd "test"...
| stdout=self._stdout, | ||
| stderr=self._stderr) | ||
| try: | ||
| self._wait_for_boot(datetime.timedelta(minutes=5)) |
There was a problem hiding this comment.
Probably worth making 5 a constant on top of the file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulator logs are stored in artifacts under test_emulator/ subdirectory.