Enable logging.

Author: vkryachko

ci/fireci/fireci/emulator.py

@@ -56,6 +56,7 @@ def __init__(
     self._stdout = self._open(log_dir, 'stdout.log')
     self._stderr = self._open(log_dir, 'stderr.log')
     self._adb_log = self._open(log_dir, 'logcat.log')
+    self._log_dir = log_dir
     self._name = name
 
     self._emulator_binary = emulator_binary
@@ -93,12 +94,12 @@ def __exit__(self, exception_type, exception_value, traceback):
     self._kill(self._logcat)
     self._close_files()
 
-  def _open(self, dirname, filename):
+  def _open(self, dirname, filename, mode='w'):
     """Opens a file in a given directory, creates directory if required."""
     dirname = os.path.join(self._artifacts_dir, dirname)
     if (not os.path.exists(dirname)):
       os.makedirs(dirname)
-    return open(os.path.join(dirname, filename), 'w')
+    return open(os.path.join(dirname, filename), mode)
 
   def _wait_for_boot(self, timeout: datetime.timedelta):
     _logger.info('Waiting for avd to boot...')
@@ -124,6 +125,10 @@ def _wait_for_boot(self, timeout: datetime.timedelta):
         self._kill(wait, sig=signal.SIGKILL)
         raise RuntimeError("Emulator startup timed out.")
 
+    with self._open(self._log_dir, 'stderr.log', mode='r') as stderr:
+      _logger.error('Emulator failed with exit code {}\n {}'.format(
+          self._process.returncode, stderr.read()))
+
     self._kill(wait)
     raise RuntimeError(
         "Emulator failed to launch. See emulator logs for details.")

ci/fireci/tests/__init__.py

@@ -11,7 +11,3 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-
-import logging
-
-logging.disable(logging.CRITICAL)