Skip to content

Remove special instructions for requiring NDK r17c. #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Remove special instructions for requiring NDK r17c. #2168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,11 +241,6 @@ projects may be published as follows.
publishProjectsToMavenLocal
```

**Note:** Firebase Crashlytics NDK requires NDK version r17c to build. Please
see the [README](firebase-crashlytics-ndk/README.md) for setup instructions.
Alternatively, if you do not need to build this project, you can safely disable
it by commenting out its reference in [subprojects.cfg](subprojects.cfg).

### Code Formatting

Code in this repo is formatted with the google-java-format tool. You can enable
Expand Down
10 changes: 1 addition & 9 deletions firebase-crashlytics-ndk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,11 @@ This component enables NDK crash reporting with Crashlytics.

## Prerequisites

This project depends on two submodules in the `third_party` directory.
This project depends on three submodules in the `third_party` directory.
Initialize them by running the following commands:

`git submodule init && git submodule update`

In addition, **this project requires NDK version r17c to build.**

### Setting up NDK r17c

1. Follow the instructions
[here](https://developer.android.com/studio/projects/install-ndk#specific-version)
to install NDK version 17.2.4988734.

## Building

All Gradle commands should be run from the root of this repository.
Expand Down