Skip to content

Remove special instructions for requiring NDK r17c. #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

mrwillis21
Copy link
Contributor

Firebase Crashlytics NDK no longer requires NDK r17c to build.

Firebase Crashlytics NDK no longer requires NDK r17c to build.
@googlebot googlebot added the cla: yes Override cla label Nov 11, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage did not change between base commit (0d3be75) and head commit (d0160c2f). However there are changes in individual files.

    Filename Base (0d3be75) Head (d0160c2f) Diff
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
    SyncTree.java 64.57% 63.57% -1.01%
  • firebase-messaging

    SDK overall coverage changed from 83.15% (0d3be75) to 83.43% (d0160c2f) by +0.28%.

    Filename Base (0d3be75) Head (d0160c2f) Diff
    TopicsSubscriber.java 88.79% 89.66% +0.86%
    TopicsSyncTask.java 49.33% 53.33% +4.00%
  • firebase-storage

    SDK overall coverage changed from 85.57% (0d3be75) to 85.48% (d0160c2f) by -0.09%.

    Filename Base (0d3be75) Head (d0160c2f) Diff
    UploadTask.java 80.95% 80.22% -0.73%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (d0160c2f) is created by Prow via merging commits: 0d3be75 37c9ef0.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2020

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (0d3be75) Head (d0160c2f) Diff
    aar 62.0 kB 62.0 kB -2 B (-0.0%)

Test Logs

Notes

Head commit (d0160c2f) is created by Prow via merging commits: 0d3be75 37c9ef0.

@mrwillis21
Copy link
Contributor Author

/retest

@mrwillis21
Copy link
Contributor Author

/test smoke-tests

@google-oss-bot
Copy link
Contributor

@mrwillis21: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 37c9ef0 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrwillis21
Copy link
Contributor Author

Skipping smoke test, as this is just a documentation update.

@mrwillis21 mrwillis21 merged commit 6e226ea into master Nov 11, 2020
@mrwillis21 mrwillis21 deleted the remove-ndk17c-instructions branch November 11, 2020 17:01
@firebase firebase locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants