Skip to content

Remove firebase-ml-natural-language related smoke tests. #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Remove firebase-ml-natural-language related smoke tests. #2109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c831fc1
Remove firebase-ml-natural-language related smoke tests.
yifanyang Oct 27, 2020
c3ac355
fix
yifanyang Oct 27, 2020
25d0b4f
Use released version of messaging.
yifanyang Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions smoke-tests/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ android {
}
}

// As required by Firebase Android Smart Reply doc:
// https://firebase.google.com/docs/ml-kit/android/generate-smart-replies#before-you-begin
aaptOptions {
noCompress "tflite"
}

if (project.hasProperty("testBuildType")) {
testBuildType project.getProperty("testBuildType")
}
Expand All @@ -75,9 +69,8 @@ dependencies {
implementation "com.google.firebase:firebase-firestore"
implementation "com.google.firebase:firebase-functions"
implementation "com.google.firebase:firebase-inappmessaging"
implementation "com.google.firebase:firebase-messaging"
implementation "com.google.firebase:firebase-ml-natural-language"
implementation "com.google.firebase:firebase-ml-natural-language-smart-reply-model"
// TODO(yifany): Remove version after messaging is up to date
implementation "com.google.firebase:firebase-messaging:21.0.0"
implementation "com.google.firebase:firebase-ml-vision"
implementation "com.google.firebase:firebase-perf"
implementation "com.google.firebase:firebase-storage"
Expand Down
6 changes: 0 additions & 6 deletions smoke-tests/src/main/java/com/google/firebase/testing/BuildOnlyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import com.google.firebase.appindexing.FirebaseAppIndex;
import com.google.firebase.inappmessaging.FirebaseInAppMessaging;
import com.google.firebase.messaging.FirebaseMessaging;
import com.google.firebase.ml.naturallanguage.FirebaseNaturalLanguage;
import com.google.firebase.perf.FirebasePerformance;
import com.google.firebase.ml.vision.FirebaseVision;
import org.junit.Test;
Expand Down Expand Up @@ -50,11 +49,6 @@ public void performance_IsNotNull() {
assertThat(FirebasePerformance.getInstance()).isNotNull();
}

@Test
public void naturalLanguage_IsNotNull() {
assertThat(FirebaseNaturalLanguage.getInstance()).isNotNull();
}

@Test
public void vision_IsNotNull() {
assertThat(FirebaseVision.getInstance()).isNotNull();
Expand Down
77 changes: 0 additions & 77 deletions smoke-tests/src/main/java/com/google/firebase/testing/SmartReplyTest.java
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion smoke-tests/src/main/java/com/google/firebase/testing/TestSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
FunctionsTest.class,
PerformanceMonitoringTest.class,
RemoteConfigTest.class,
SmartReplyTest.class,
StorageTest.class,
})
public final class TestSuite {}