Skip to content

Remove firebase-ml-natural-language related smoke tests. #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

yifanyang
Copy link
Contributor

firebase-ml-natural-language is deprecated in 10/27/2020 release.

https://firebase.google.com/support/release-notes/android#2020-10-27

@google-cla google-cla bot added the cla: yes Override cla label Oct 27, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2020

Binary Size Report

Affected SDKs

No changes between base commit (51c995e) and head commit (2b2cacc2).

Test Logs

Notes

Head commit (2b2cacc2) is created by Prow via merging commits: 51c995e 25d0b4f.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.97% (51c995e) to 51.01% (2b2cacc2) by +0.03%.

    Filename Base (51c995e) Head (2b2cacc2) Diff
    BooleanNode.java 100.00% 92.31% -7.69%
    ChildChangeAccumulator.java 83.33% 96.67% +13.33%
  • firebase-messaging

    SDK overall coverage changed from ? (51c995e) to 83.43% (2b2cacc2) by ?.

    Click to show coverage changes in 23 files.
    Filename Base (51c995e) Head (2b2cacc2) Diff
    CommonNotificationBuilder.java ? 91.63% ?
    Constants.java ? 92.86% ?
    DisplayNotification.java ? 91.38% ?
    EnhancedIntentService.java ? 80.00% ?
    ExecutorFactory.java ? 0.00% ?
    FcmExecutors.java ? 85.71% ?
    FirebaseMessaging.java ? 65.00% ?
    FirebaseMessagingRegistrar.java ? 83.33% ?
    FirebaseMessagingService.java ? 94.79% ?
    FirelogAnalyticsEvent.java ? 26.67% ?
    ImageDownload.java ? 87.18% ?
    MessagingAnalytics.java ? 63.93% ?
    NotificationParams.java ? 98.71% ?
    PoolableExecutors.java ? 29.17% ?
    RemoteMessage.java ? 95.48% ?
    RemoteMessageCreator.java ? 88.89% ?
    SendException.java ? 100.00% ?
    SharedPreferencesQueue.java ? 98.44% ?
    ThreadPriority.java ? 100.00% ?
    TopicOperation.java ? 90.00% ?
    TopicsStore.java ? 100.00% ?
    TopicsSubscriber.java ? 89.66% ?
    TopicsSyncTask.java ? 53.33% ?
  • firebase-storage

    SDK overall coverage changed from 85.57% (51c995e) to 85.48% (2b2cacc2) by -0.09%.

    Filename Base (51c995e) Head (2b2cacc2) Diff
    UploadTask.java 80.95% 80.22% -0.73%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (2b2cacc2) is created by Prow via merging commits: 51c995e 25d0b4f.

@google-oss-bot
Copy link
Contributor

@yifanyang: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 25d0b4f link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yifanyang yifanyang merged commit 844ff28 into master Oct 27, 2020
@yifanyang yifanyang deleted the yifany/smoke-tests branch October 27, 2020 21:05
@annzimmer
Copy link
Contributor

/retest

@firebase firebase locked and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants