Split UserDataConverter in two #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits ParseAccumulator from ParseContext and moves shared user data classes like ParsedSetData and ParsedUpdateData to core. This matches the reorganization in firebase/firebase-ios-sdk#1823 where the changes have a more direct benefit. This change mostly just keeps the ports in sync.
|
This isn't ready after all. Pay no mind. |
|
Now self-contained. |
|
/test check |
1 similar comment
|
/test check |
mikelehen
approved these changes
Sep 17, 2018
firebase-firestore/src/main/java/com/google/firebase/firestore/core/UserData.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/UserData.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/UserData.java
Outdated
Show resolved
Hide resolved
firebase-firestore/src/main/java/com/google/firebase/firestore/core/UserData.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits ParseAccumulator from ParseContext and moves shared user data
classes like ParsedSetData and ParsedUpdateData to core.
This matches the reorganization in firebase/firebase-ios-sdk#1823 where
the changes have a more direct benefit. This change mostly just keeps
the ports in sync.