Split UserDataConverter in two (#21)

* Split UserDataConverter in two

Splits ParseAccumulator from ParseContext and moves shared user data
classes like ParsedSetData and ParsedUpdateData to core.

This matches the reorganization in firebase/firebase-ios-sdk#1823 where
the changes have a more direct benefit. This change mostly just keeps
the ports in sync.

Author: wilhuff

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/ValidationTest.java

@@ -35,7 +35,6 @@
 import com.google.firebase.firestore.Transaction.Function;
 import com.google.firebase.firestore.testutil.IntegrationTestUtil;
 import com.google.firebase.firestore.util.Consumer;
-import java.util.Arrays;
 import java.util.Date;
 import java.util.List;
 import java.util.Map;
@@ -44,6 +43,7 @@
 import org.junit.runner.RunWith;
 
 // NOTE: The SDK has exhaustive nullability checks, but we don't exhaustively test them. :-)
+@SuppressWarnings("ConstantConditions")
 @RunWith(AndroidJUnit4.class)
 public class ValidationTest {
 
@@ -387,9 +387,8 @@ public void arrayTransformsRejectArrays() {
     DocumentReference doc = testDocument();
     // This would result in a directly nested array which is not supported.
     String reason = "Invalid data. Nested arrays are not supported";
-    expectError(() -> doc.set(map("x", FieldValue.arrayUnion(1, Arrays.asList("nested")))), reason);
-    expectError(
-        () -> doc.set(map("x", FieldValue.arrayRemove(1, Arrays.asList("nested")))), reason);
+    expectError(() -> doc.set(map("x", FieldValue.arrayUnion(1, asList("nested")))), reason);
+    expectError(() -> doc.set(map("x", FieldValue.arrayRemove(1, asList("nested")))), reason);
   }
 
   @Test

firebase-firestore/src/main/java/com/google/firebase/firestore/DocumentReference.java

@@ -26,10 +26,10 @@
 import com.google.android.gms.tasks.Tasks;
 import com.google.firebase.annotations.PublicApi;
 import com.google.firebase.firestore.FirebaseFirestoreException.Code;
-import com.google.firebase.firestore.UserDataConverter.ParsedDocumentData;
-import com.google.firebase.firestore.UserDataConverter.ParsedUpdateData;
 import com.google.firebase.firestore.core.EventManager.ListenOptions;
 import com.google.firebase.firestore.core.QueryListener;
+import com.google.firebase.firestore.core.UserData.ParsedSetData;
+import com.google.firebase.firestore.core.UserData.ParsedUpdateData;
 import com.google.firebase.firestore.core.ViewSnapshot;
 import com.google.firebase.firestore.model.Document;
 import com.google.firebase.firestore.model.DocumentKey;
@@ -166,7 +166,7 @@ public Task<Void> set(@NonNull Map<String, Object> data) {
   public Task<Void> set(@NonNull Map<String, Object> data, @NonNull SetOptions options) {
     checkNotNull(data, "Provided data must not be null.");
     checkNotNull(options, "Provided options must not be null.");
-    ParsedDocumentData parsed =
+    ParsedSetData parsed =
         options.isMerge()
             ? firestore.getDataConverter().parseMergeData(data, options.getFieldMask())
             : firestore.getDataConverter().parseSetData(data);

firebase-firestore/src/main/java/com/google/firebase/firestore/Transaction.java

@@ -21,8 +21,8 @@
 import com.google.android.gms.tasks.Task;
 import com.google.android.gms.tasks.Tasks;
 import com.google.firebase.annotations.PublicApi;
-import com.google.firebase.firestore.UserDataConverter.ParsedDocumentData;
-import com.google.firebase.firestore.UserDataConverter.ParsedUpdateData;
+import com.google.firebase.firestore.core.UserData.ParsedSetData;
+import com.google.firebase.firestore.core.UserData.ParsedUpdateData;
 import com.google.firebase.firestore.model.Document;
 import com.google.firebase.firestore.model.MaybeDocument;
 import com.google.firebase.firestore.model.NoDocument;
@@ -89,7 +89,7 @@ public Transaction set(
     firestore.validateReference(documentRef);
     checkNotNull(data, "Provided data must not be null.");
     checkNotNull(options, "Provided options must not be null.");
-    ParsedDocumentData parsed =
+    ParsedSetData parsed =
         options.isMerge()
             ? firestore.getDataConverter().parseMergeData(data, options.getFieldMask())
             : firestore.getDataConverter().parseSetData(data);