Skip to content

docs(fdl-ktx): document the Kotlin destructuring declarations #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

thatfiredev
Copy link
Member

DO NOT MERGE before the next release (after 19.1.0) of dynamic-links-ktx.

This should document the new features added in #1753

@googlebot googlebot added the cla: yes Override cla label Aug 13, 2020
@google-oss-bot
Copy link
Contributor

Hi @rosariopfernandes. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlazo
Copy link
Collaborator

rlazo commented Aug 17, 2020

/ok-to-test

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 17, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.97% (a9a6b9c) to 50.96% (2ddcc0c0) by -0.01%.

    Filename Base (a9a6b9c) Head (2ddcc0c0) Diff
    DefaultPersistenceManager.java 74.76% 75.73% +0.97%
    RetryHelper.java 74.19% 70.97% -3.23%
  • firebase-firestore

    SDK overall coverage changed from 46.83% (a9a6b9c) to 46.85% (2ddcc0c0) by +0.02%.

    Filename Base (a9a6b9c) Head (2ddcc0c0) Diff
    AbstractStream.java 34.52% 36.90% +2.38%
  • firebase-messaging

    SDK overall coverage changed from 83.43% (a9a6b9c) to 83.56% (2ddcc0c0) by +0.14%.

    Filename Base (a9a6b9c) Head (2ddcc0c0) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (2ddcc0c0) is created by Prow via merging commits: a9a6b9c d0ae743.

@rlazo
Copy link
Collaborator

rlazo commented Aug 17, 2020

/test check-changed

@rlazo
Copy link
Collaborator

rlazo commented Nov 10, 2020

/retest

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 10, 2020

@rosariopfernandes: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests d0ae743 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo
Copy link
Collaborator

rlazo commented Nov 10, 2020

Thanks a lot for your contribution @rosariopfernandes !

@rlazo rlazo merged commit 4073143 into firebase:master Nov 10, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-installations

    Type Base (a9a6b9c) Head (2ddcc0c0) Diff
    aar 62.0 kB 62.0 kB -5 B (-0.0%)

Test Logs

Notes

Head commit (2ddcc0c0) is created by Prow via merging commits: a9a6b9c d0ae743.

@thatfiredev thatfiredev deleted the rpf-fdl-ktx-docs branch November 10, 2020 17:59
@firebase firebase locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants